Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "🐛 Fix permissionclaim patch thrashing" #2176

Closed
wants to merge 1 commit into from

Conversation

sttts
Copy link
Member

@sttts sttts commented Oct 12, 2022

Reverts #2174

@openshift-ci openshift-ci bot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Oct 12, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 12, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from sttts by writing /assign @sttts in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ncdc
Copy link
Member

ncdc commented Oct 12, 2022

Would prefer a new PR that fixes the list type instead of a revert if possible

@sttts
Copy link
Member Author

sttts commented Oct 12, 2022

/hold

This is a placeholder for a discussion about a real solution.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 12, 2022
@ncdc
Copy link
Member

ncdc commented Oct 12, 2022

#2177 reverts the part of #2174 we don't actually want
/close

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 12, 2022

@ncdc: Closed this PR.

In response to this:

#2177 reverts the part of #2174 we don't actually want
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot closed this Oct 12, 2022
@ncdc ncdc deleted the revert-2174-fix-permissionclaim-patch-thrashing branch October 13, 2022 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants