pypi install-ability #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* setup.py shim is needed to prevent "UNKNOWN-0.0.0" eggs * Manifest wasn't including `pywfa/WFA2_lib/*` so Makefiles etc were being dropped * Manifest now also pulls in the `_custom_build.py` * `python3 setup.py sdist` works * `_custom_build.py` command was always returning retcode 0 due to final `cd ../`. Can now catch make fails * `python3 -m pip install -e .` now works * bumping version to 0.5 since at least once I saw pip silently replace 0.4.2 with 0.4.1
left intermediate, non-working lines commented out in the code
including removing -dev from version
|
Thanks again, it seems there are so many traps to fall in to. I tested this PR on testPypi and it seemed to work fine. Happy to merge and put on pypi |
|
Looks like it works! Thanks for putting this out there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Turns out there was more to be done. The tl;dr; is that we still need a shim
setup.py, and a few other things changed.When I tried to install pywfa for a package feature I'm testing, the github action that tests my package wasn't able to successfully install pywfa==0.4.2. I was getting an error that pywfa was named "UNKNOWN-0.0.0"
full error
I also needed to fix the
MANIFEST.into include the_custom_build.pyand Makefile inpywfa/WFA2_lib/*. Also, the new_custom_build.pyhas a check to ensure that the make command works. However, the make command never exited non-zero due to only returning the status of the final command (wascd pywfa/WFA2_lib; make .. ; cd ../).I believe these changes should work better because I was able to get
python3 setup.py sdistto create a valid, usablepython3 -m pip install dist/pywfa-0.5.0.dev1.tar.gz. And by having the shim, things likepip install -eseem to work. Furthermore, I successfully tested by editing my github action to pull directly via:python3 -m pip install 'pywfa @ git+https://github.com/ACEnglish/pywfa'. Which is great, but I don't know if this is a great emulation of what pypi will make.Finally, I bumped the version to 0.5.0-dev. At least once trying to install 0.4.2 failed and pip slyly installed 0.4.1 instead (which had caused the old
undefined symbol: wavefront_align). I'm guessing that bumping the minor version instead of the patch may prevent this.I don't know your workflow for distributing to pypi, but if possible, could you try a test.pypi.org upload before pushing to regular pypi? If there's more problems, we'll at least not be filling it up with my mistakes lol.
Have a great day,
~/Adam English