Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to React 16 #9

Closed
kay-is opened this issue Apr 14, 2018 · 3 comments
Closed

Update to React 16 #9

kay-is opened this issue Apr 14, 2018 · 3 comments

Comments

@kay-is
Copy link
Owner

kay-is commented Apr 14, 2018

Saw that this repository somehow ended up as one of the most popular courses on Github (based on stars, lol)

Anyway, the current version of React is 16.3.1 and this course is based on 15.4.2 Some things have changed and need to be adressed. (PropTypes, context, lifecycle methods, etc. pp.)

Also, maybe this course could use some updates in general.

So what steps need to be taken?

  1. Someone needs to check what changed since 15.4.2
  2. Someone needs to write PRs to adress these changes

I'm using a rather old version of Babel to enable in-browser compilation of JSX, we probably need to check if this will still work with the new React version.

If someone is interested in this, just go for it.

@kay-is
Copy link
Owner Author

kay-is commented May 29, 2018

Also some advanced lessons for higher order components and render props/function as children would be nice.

@kay-is
Copy link
Owner Author

kay-is commented Jun 4, 2018

Seemingly babel-core isn't the way to go anymore, babel-standalone is and it's also integrated into the main Babel repo.

https://new.babeljs.io/docs/en/next/babel-standalone.html

kay-is added a commit that referenced this issue Jun 5, 2018
kay-is added a commit that referenced this issue Jun 5, 2018
@kay-is
Copy link
Owner Author

kay-is commented Jun 5, 2018

With version 16 React.PropTypes and React.createClass are gone. These now require some extra packages.

Also, if you create element objects manually, you need to set ref explicitly to null or React 16 will complain.

@kay-is kay-is closed this as completed Jun 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant