Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misnomer: react-from-zero - not from zero #21

Closed
AndrewMcSwain opened this issue Jul 7, 2018 · 2 comments
Closed

Misnomer: react-from-zero - not from zero #21

AndrewMcSwain opened this issue Jul 7, 2018 · 2 comments

Comments

@AndrewMcSwain
Copy link

AndrewMcSwain commented Jul 7, 2018

Correct me if i'm wrong. I very well could be, since I'm starting from zero. This tutorial seems like more of a reference for implementing the individual techniques used in creating an app with react, rather than a tutorial 'from zero'. Shouldn't there be an explicit overview of the structure? To elucidate what I mean by structure, take, for instance, this question: where do i put these examples in a new instance of create-react-app / App.js ?

For reference ´App.js´:

import React, { Component } from 'react';
import logo from './logo.svg';
import './App.css';

class App extends Component {
  render() {
    return (
      <div className="App">
        <header className="App-header">
          <img src={logo} className="App-logo" alt="logo" />
          <h1 className="App-title">Welcome to React</h1>
        </header>
        <p className="App-intro">
          To get started, edit <code>src/App.js</code> and save to reload.
      </div>
    );
  }
}

export default App;

@kay-is
Copy link
Owner

kay-is commented Jul 7, 2018

Good point.

I think if you look at the index.js instead of the App.js, things should be clearer.

Maybe I should add some infos about this to the readme.

kay-is added a commit that referenced this issue Jul 7, 2018
@kay-is
Copy link
Owner

kay-is commented Jul 7, 2018

Hope the info I added helps :)

@kay-is kay-is closed this as completed Jul 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants