Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thread safety #30

Merged
merged 1 commit into from
Oct 18, 2018
Merged

Thread safety #30

merged 1 commit into from
Oct 18, 2018

Conversation

kawoou
Copy link
Owner

@kawoou kawoou commented Oct 14, 2018

Results tried a simple test, I found that not thread safety.
Therefore, I changed Mutex to NSRecursiveLock and increased the lock coverage.

@kawoou kawoou added the bug Something isn't working label Oct 14, 2018
@kawoou kawoou self-assigned this Oct 14, 2018
@kawoou kawoou changed the title Thread safety. Thread safety Oct 14, 2018
@codecov-io
Copy link

codecov-io commented Oct 14, 2018

Codecov Report

Merging #30 into develop will decrease coverage by 0.79%.
The diff coverage is 85.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop      #30     +/-   ##
==========================================
- Coverage    66.36%   65.57%   -0.8%     
==========================================
  Files           17       16      -1     
  Lines          559      549     -10     
==========================================
- Hits           371      360     -11     
- Misses         188      189      +1
Impacted Files Coverage Δ
Sources/Deli/Core/Container.swift 69.15% <76.92%> (-2.54%) ⬇️
Sources/Deli/Core/AppContext.swift 96.87% <96.66%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8618a2b...0868aa1. Read the comment docs.

@kawoou kawoou merged commit ec1be53 into develop Oct 18, 2018
@kawoou kawoou deleted the feature/thread branch October 18, 2018 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants