Add CLI option to force output resample rate

[christophehenry]

No description provided.

[sezanzeb]

Can't run the ui anymore:

➜  soundconverter git:(resample-rate) soundconverter
/usr/lib/python3.9/site-packages/soundconverter/interface/preferences.py:27: PyGIWarning: Gtk was imported without specifying a version first. Use gi.require_version('Gtk', '4.0') before import to ensure that the right version gets loaded.
  from gi.repository import Gtk, GLib
/usr/lib/python3.9/site-packages/soundconverter/gstreamer/converter.py:26: PyGIWarning: Gst was imported without specifying a version first. Use gi.require_version('Gst', '1.0') before import to ensure that the right version gets loaded.
  from gi.repository import Gst, GLib, Gio
soundconverter needs GTK >= 3.0 (Error: "Namespace Gtk is already loaded with version 4.0")

[kassoulet]

Hi Christophe, I'm afraid tests are not passing. I'll look when I get some time, but feel free to resubmit if you manage to fix them. ====================================================================== ERROR: test_validate_args (testcases.batch.BatchUtils) ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/gautier/Downloads/soundconverter-resample-rate/tests/testcases/batch.py", line 268, in test_validate_args self.assertFalse(validate_args({'output-resample': 160})) File "/usr/local/lib/python3.8/dist-packages/soundconverter/interface/batch.py", line 243, in validate_args "Possible values for -R or --output-resample option are {rates}".format(rates=", ".join(rates)) TypeError: sequence item 0: expected str instance, int found ====================================================================== FAIL: test_set_output_sample (testcases.batch.BatchUtils) ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/gautier/Downloads/soundconverter-resample-rate/tests/testcases/batch.py", line 370, in test_set_output_sample self.assertEqual(44100, gio_settings.get_boolean('output-resample')) AssertionError: 44100 != True ====================================================================== FAIL: test_set_output_resample (testcases.integration.BatchIntegration) ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/gautier/Downloads/soundconverter-resample-rate/tests/testcases/integration.py", line 464, in test_set_output_resample self.assertIsNone(gio_settings.get_boolean('output-resample')) AssertionError: False is not None ====================================================================== FAIL: test_conversion_pattern (testcases.integration.GUI) ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/gautier/Downloads/soundconverter-resample-rate/tests/testcases/integration.py", line 911, in test_conversion_pattern self.assertTrue(os.path.isfile( AssertionError: False is not true

…

On Sun, 16 Jan 2022 at 19:06, Christophe Henry ***@***.***> wrote: ------------------------------ You can view, comment on, or merge this pull request online at: #62 Commit Summary - 57701ad <57701ad> Add --output-rate CLI option File Changes (5 files <https://github.com/kassoulet/soundconverter/pull/62/files>) - *M* bin/soundconverter <https://github.com/kassoulet/soundconverter/pull/62/files#diff-3eb06c7fe175a6f355c71601a77e3aa8ad5eb30568a21997d11f845634f2fe26> (9) - *M* soundconverter/interface/batch.py <https://github.com/kassoulet/soundconverter/pull/62/files#diff-8eec72c7de924035b6a71d35ed9844a97e06f32d7deb9c7fc4b5469e2fe8d988> (15) - *M* soundconverter/interface/preferences.py <https://github.com/kassoulet/soundconverter/pull/62/files#diff-a1405c5cf542562cd116d58fb2e8cd1c82b147aa386b94ae48b4d43e4e1ab765> (4) - *M* tests/testcases/batch.py <https://github.com/kassoulet/soundconverter/pull/62/files#diff-3b80b3b0ea21ae5c9374ed89ddb3487196649760bf6c72dc97eaa8b305344cab> (20) - *M* tests/testcases/integration.py <https://github.com/kassoulet/soundconverter/pull/62/files#diff-5f9c3f5fc52b012941051a7d03d5d88a724d3f83cb68e46ab75a79be49d6ec64> (27) Patch Links: - https://github.com/kassoulet/soundconverter/pull/62.patch - https://github.com/kassoulet/soundconverter/pull/62.diff — Reply to this email directly, view it on GitHub <#62>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAAO4JOT4IG2CYPP3VO73TUWMCLDANCNFSM5MDBCNPQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[christophehenry]

@sezanzeb Fixed.
@kassoulet Fixed too. Only one test failing because I don't know how get_bitrate() actually computes the bitrate. If you could help me.

[kassoulet]

Nice, thank you Christophe !