Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More precise remaining time calculation, ui.py split #42

Draft
wants to merge 11 commits into
base: py3k
Choose a base branch
from
Draft

More precise remaining time calculation, ui.py split #42

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
a152389
idk
Sep 5, 2020
cf5d6b2
split ui.py, more accurate remaining time calculation, better progres…
Sep 6, 2020
085721b
some improvements to the ProgressBar class
Sep 6, 2020
c248e45
fixed tests
Sep 6, 2020
89f3ea7
not sure if that docstring made sense
Sep 6, 2020
77b2b1e
some potential improvements to the calculation
Sep 6, 2020
dc34720
discovering the type of audio
Sep 6, 2020
9a58bb2
conversion is marked done when skipping existing files
Sep 6, 2020
3116154
comment clarification
Sep 6, 2020
0c0eb45
Merge remote-tracking branch 'remotes/original/py3k' into precise-rem…
Sep 7, 2020
04eee8b
merge py3k
Sep 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
conversion is marked done when skipping existing files
  • Loading branch information
sezanzeb committed Sep 6, 2020
commit 9a58bb23bef3422025a3be09210a3f36e52556a0
1 change: 1 addition & 0 deletions soundconverter/gstreamer/converter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,6 +426,7 @@ def run(self):
logger.info('output file already exists, skipping \'{}\''.format(
beautify_uri(self.newname)
))
self.done = True
self._conversion_done()
return

Expand Down
4 changes: 2 additions & 2 deletions soundconverter/util/taskqueue.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,8 +122,8 @@ def task_done(self, task):
"""
if task.get_progress()[0] != 1:
raise ValueError(
f'Task with a progress of {task.get_progress()[0]} called '
'task_done'
f'{task.__class__.__name__} Task with a progress of '
f'{task.get_progress()[0]} called task_done'
)
self.done.append(task)
if task not in self.running:
Expand Down