Logs and codestyle #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 30, 2020 10:32
|
Thank you! |
sezanzeb
pushed a commit
to sezanzeb/soundconverter
that referenced
this pull request
Jun 20, 2020
Logs and codestyle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to better debug this: https://bugs.launchpad.net/soundconverter/+bug/1881376 new logs were added that hopefully show when errors happen during conversion. Also, some numbers used to get spammed into the console.
The code is now mostly compliant with
pycodestyle, though I set max-line-length to 120 because for now I didn't want to also deal with that.Those docstrings that exist are mostly compliant with
pydocstylenow.