Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Timeout with an async iteration #832

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

bjchambers
Copy link
Collaborator

No description provided.

@cla-bot cla-bot bot added the cla-signed Set when all authors of a PR have signed our CLA label Oct 26, 2023
@github-actions github-actions bot added the test label Oct 26, 2023
golden.jsonl(await execution.__anext__())

with pytest.raises(TimeoutError):
async with asyncio.timeout(1):
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if we want to check this in without marking it as a slow test. Specifically, it will wait at least 1 second for the timeout to occur. This can be increased further (10s) to verify that it isn't just "getting lucky" in terms of hitting an empty batch or somethnig like that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed Set when all authors of a PR have signed our CLA test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant