Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: fix default schema in inference for map/list #577

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

jordanrfrazier
Copy link
Collaborator

@jordanrfrazier jordanrfrazier commented Aug 1, 2023

Fixes the default schema for the map and list types in inference. This isn't a good solution, as there's no guarantee that Arrow doesn't change this behavior in the future. Ideally, we can figure out how to plumb the user map type information through inference. But, it's difficult because functions that produce map or list types need an arbitrary naming/nullability that we define.

Closes #576

@cla-bot cla-bot bot added the cla-signed Set when all authors of a PR have signed our CLA label Aug 1, 2023
@github-actions github-actions bot added bug Something isn't working sparrow labels Aug 1, 2023
@jordanrfrazier jordanrfrazier added this pull request to the merge queue Aug 1, 2023
Merged via the queue into main with commit d5960e7 Aug 1, 2023
33 checks passed
@jordanrfrazier jordanrfrazier deleted the map-list-minor-bug-fixes branch August 1, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cla-signed Set when all authors of a PR have signed our CLA sparrow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: using get with a list or index with a map panics
2 participants