Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: fix non-generic conversions in string spread #563

Merged
merged 2 commits into from
Jul 28, 2023
Merged

bug: fix non-generic conversions in string spread #563

merged 2 commits into from
Jul 28, 2023

Conversation

jordanrfrazier
Copy link
Collaborator

@jordanrfrazier jordanrfrazier commented Jul 27, 2023 •
edited
Loading

Fixes spots in string spread that weren't generic

@cla-bot cla-bot bot added the cla-signed Set when all authors of a PR have signed our CLA label Jul 27, 2023
@github-actions github-actions bot added bug Something isn't working sparrow labels Jul 27, 2023
@jordanrfrazier jordanrfrazier changed the title bug: add large utf8 to spread without generics bug: fix non-generic conversions in string spread Jul 28, 2023
@jordanrfrazier jordanrfrazier added this pull request to the merge queue Jul 28, 2023
Merged via the queue into main with commit 2f45a40 Jul 28, 2023
33 checks passed
@jordanrfrazier jordanrfrazier deleted the fix-large-utf8-spread branch July 28, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjchambers bjchambers bjchambers approved these changes

@therapon therapon Awaiting requested review from therapon

Assignees
No one assigned
Labels
bug Something isn't working cla-signed Set when all authors of a PR have signed our CLA sparrow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jordanrfrazier @bjchambers