Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: index for DataType::List #562

Merged
merged 10 commits into from
Jul 27, 2023
Merged

feat: index for DataType::List #562

merged 10 commits into from
Jul 27, 2023

Conversation

jordanrfrazier
Copy link
Collaborator

Adds type inference support for lists and adds just the index function.

Further additions: #494

@cla-bot cla-bot bot added the cla-signed Set when all authors of a PR have signed our CLA label Jul 27, 2023
@github-actions github-actions bot added enhancement New feature or request proto sparrow labels Jul 27, 2023
@jordanrfrazier jordanrfrazier mentioned this pull request Jul 27, 2023
Open
37 tasks
@jordanrfrazier
Copy link
Collaborator Author

NOTE: Happy to discuss going to get_map and get_list instead of get/index naming

@bjchambers
Copy link
Collaborator

NOTE: Happy to discuss going to get_map and get_list instead of get/index naming

I'm somewhat fine with either. I suspect if we lean towards the Python side, I'd prefer more specific names (get_map and get_list and then we can have the Python layer choose the specific name to use for a more user-friendly name), as shown in #561.

bjchambers
bjchambers approved these changes Jul 27, 2023
View reviewed changes
crates/sparrow-arrow/src/downcast.rs Outdated Show resolved Hide resolved
crates/sparrow-instructions/src/evaluators/list/index.rs Outdated Show resolved Hide resolved
@jordanrfrazier jordanrfrazier added this pull request to the merge queue Jul 27, 2023
Merged via the queue into main with commit 82adac4 Jul 27, 2023
31 checks passed
@jordanrfrazier jordanrfrazier deleted the collect-to-list branch July 27, 2023 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjchambers bjchambers bjchambers approved these changes

Assignees
No one assigned
Labels
cla-signed Set when all authors of a PR have signed our CLA enhancement New feature or request proto sparrow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jordanrfrazier @bjchambers