Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactored the compute package into several interfaces #386

Merged
merged 2 commits into from
May 25, 2023
Merged

refactored the compute package into several interfaces #386

merged 2 commits into from
May 25, 2023

Conversation

epinzur
Copy link
Collaborator

@epinzur epinzur commented May 25, 2023

now have:

  • CompileManager
  • ComputeManager
  • FileManager
  • PrepareManager
  • MaterializationManager

@github-actions github-actions bot added the wren label May 25, 2023
@epinzur epinzur enabled auto-merge May 25, 2023 13:17
kerinin
kerinin approved these changes May 25, 2023
View reviewed changes
Copy link
Collaborator

@kerinin kerinin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I don't have a ton of familiarity with the code at this point.

@epinzur epinzur added this pull request to the merge queue May 25, 2023
Merged via the queue into main with commit e0525e9 May 25, 2023
30 checks passed
@epinzur epinzur deleted the wren/refac_compute branch May 25, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kerinin kerinin kerinin approved these changes

Assignees
No one assigned
Labels
wren
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@epinzur @kerinin