Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add template .gitattributes that fixes language stats #115

Merged
merged 2 commits into from
Feb 4, 2023

Conversation

akashmjn
Copy link
Contributor

@akashmjn akashmjn commented Feb 3, 2023

Tiny PR to fix the annoying jupyter notebook language count stats :)

https://twitter.com/karpathy/status/1620875263700799488?s=20&t=bV2NXNJaUzxcZWsUyDyJEg

Instructions taken from https://github.com/github/linguist/blob/master/docs/overrides.md#generated-code, referenced in discussion under github-linguist/linguist#3316 (official github-linguist repo).

I left the rest of the commented template lines in there in case you need anything from there, but could remove them if you really want to keep it "nano" 😉

@karpathy
Copy link
Owner

karpathy commented Feb 3, 2023

why is this file so long? does it need to be just that 1 line with a comment?

@akashmjn
Copy link
Contributor Author

akashmjn commented Feb 3, 2023

Correct, you only really need lines 6-8

Initially lazily copied a template i'd used elsewhere in case something else may be of use (just looked, it isn't). Fixing in follow up.

@karpathy karpathy merged commit 46428d3 into karpathy:master Feb 4, 2023
@karpathy
Copy link
Owner

karpathy commented Feb 4, 2023

cool, let's see what happens :) ty!

@karpathy
Copy link
Owner

karpathy commented Feb 4, 2023

i think it worked, ty :)
image

@akashmjn
Copy link
Contributor Author

akashmjn commented Feb 4, 2023

Nice! 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants