Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calculate key and value inside the kv cache #400

Merged
merged 2 commits into from
Oct 9, 2023

Conversation

kroggen
Copy link
Contributor

@kroggen kroggen commented Sep 14, 2023

Less memory allocation and less memory copy

I just don't know if it is clear enough for understanding / learning

@kroggen
Copy link
Contributor Author

kroggen commented Sep 14, 2023

This PR is compatible with PR #397. They can be merged without conflicts

@karpathy karpathy merged commit 1fcdf04 into karpathy:master Oct 9, 2023
6 checks passed
@karpathy
Copy link
Owner

karpathy commented Oct 9, 2023

Ok, ty

@kroggen kroggen deleted the use-kv-cache branch October 9, 2023 23:11
vinhtran2611 pushed a commit to vinhtran2611/llama2.c that referenced this pull request Jan 20, 2024
calculate key and value inside the kv cache
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants