Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] Enhancing AssignREplicas with Plugins #5218

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Vacant2333
Copy link
Contributor

What type of PR is this?
/kind feature

Which issue(s) this PR fixes:
From: #4919

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@karmada-bot karmada-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. labels Jul 18, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign xishanyongye-chang for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 18, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 18, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.53%. Comparing base (a87ec2a) to head (fd852bf).
Report is 121 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5218      +/-   ##
==========================================
+ Coverage   28.23%   28.53%   +0.30%     
==========================================
  Files         632      632              
  Lines       43723    43856     +133     
==========================================
+ Hits        12345    12515     +170     
+ Misses      30473    30443      -30     
+ Partials      905      898       -7     
Flag Coverage Δ
unittests 28.53% <ø> (+0.30%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Vacant2333 Vacant2333 force-pushed the proposal-for-scheduler-support-plugin-when-assign-replicas branch from 0012ae0 to a661a71 Compare July 19, 2024 03:50
@Vacant2333 Vacant2333 force-pushed the proposal-for-scheduler-support-plugin-when-assign-replicas branch from a661a71 to b33df88 Compare August 3, 2024 10:13
@Vacant2333 Vacant2333 force-pushed the proposal-for-scheduler-support-plugin-when-assign-replicas branch from b33df88 to fd852bf Compare August 11, 2024 16:35
@Vacant2333 Vacant2333 changed the title [WIP][Proposal] Scheduler support custom plugin when AssignReplicas [Proposal] Enhancing AssignREplicas with Plugins Aug 11, 2024
@Vacant2333 Vacant2333 marked this pull request as ready for review August 11, 2024 16:36
@karmada-bot karmada-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants