Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid ES6+ syntax in client scripts #3629

Merged
merged 3 commits into from
Jan 25, 2021
Merged

fix: avoid ES6+ syntax in client scripts #3629

merged 3 commits into from
Jan 25, 2021

Conversation

longlho
Copy link
Contributor

@longlho longlho commented Jan 22, 2021 •
edited
Loading

We use karma to run unit tests on browser and it crashes on IE11 & old Chrome because of invalid token (template literal in this case). This only happens on v6.x

@AppVeyorBot
Copy link

✅ Build karma 2875 completed (commit b27b961737 by @longlho)

@karmarunnerbot
Copy link
Member

✅ Build karma 478 completed (commit b27b961737 by @longlho)

@karmarunnerbot
Copy link
Member

✅ Build karma 477 completed (commit b27b961737 by @longlho)

@AppVeyorBot
Copy link

✅ Build karma 2876 completed (commit f6cad3f80c by @longlho)

@karmarunnerbot
Copy link
Member

✅ Build karma 479 completed (commit f6cad3f80c by @longlho)

@karmarunnerbot
Copy link
Member

✅ Build karma 478 completed (commit f6cad3f80c by @longlho)

@karmarunnerbot
Copy link
Member

✅ Build karma 480 completed (commit be94bf9cd8 by @longlho)

@AppVeyorBot
Copy link

✅ Build karma 2877 completed (commit be94bf9cd8 by @longlho)

@karmarunnerbot
Copy link
Member

✅ Build karma 479 completed (commit be94bf9cd8 by @longlho)

@longlho longlho mentioned this pull request Jan 22, 2021
Closed
@Trott
Copy link
Contributor

Trott commented Jan 22, 2021

I've applied this patch and confirmed that it fixes karma-runner/karma-sauce-launcher#238.

@longlho longlho changed the title fix: remove template literal that breaks old browsers fix: avoid ES6+ syntax in client scripts Jan 23, 2021
devoto13
devoto13 approved these changes Jan 24, 2021
View reviewed changes
Copy link
Collaborator

@devoto13 devoto13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@devoto13 devoto13 mentioned this pull request Jan 25, 2021
Closed
jginsburgn
jginsburgn approved these changes Jan 25, 2021
View reviewed changes
Copy link
Member

@jginsburgn jginsburgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix: #3630

@johnjbarton
Copy link
Contributor

Sorry but there are other template literals that need to be fixed.

johnjbarton added a commit to johnjbarton/karma that referenced this pull request Jan 25, 2021
@johnjbarton
fix(client): revert modern syntax to allow IE11 use
ae90668 
Fixes karma-runner#3629 karma-runner#3630
@johnjbarton johnjbarton mentioned this pull request Jan 25, 2021
Closed
@johnjbarton johnjbarton merged commit 6629e96 into karma-runner:master Jan 25, 2021
@longlho longlho deleted the patch-1 branch January 25, 2021 20:45
karmarunnerbot pushed a commit that referenced this pull request Jan 25, 2021
@semantic-release-bot
chore(release): 6.0.2 [skip ci]
b5c0baa 
## [6.0.2](v6.0.1...v6.0.2) (2021-01-25)

### Bug Fixes

* avoid ES6+ syntax in client scripts ([#3629](#3629)) ([6629e96](6629e96)), closes [#3630](#3630)
@karmarunnerbot
Copy link
Member

🎉 This PR is included in version 6.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

This was referenced Mar 9, 2021
Closed
Closed
Closed
This was referenced Mar 9, 2021
Closed
Closed
Closed
Closed
@karronoli karronoli mentioned this pull request Aug 16, 2022
Merged
anthony-redFox pushed a commit to anthony-redFox/karma that referenced this pull request May 16, 2023
@longlho @anthony-redFox
fix: avoid ES6+ syntax in client scripts (karma-runner#3629)
8fb5802 
* remove template literals and arrow functions that break in IE11 
Fixes karma-runner#3630
anthony-redFox pushed a commit to anthony-redFox/karma that referenced this pull request May 16, 2023
@semantic-release-bot @anthony-redFox
chore(release): 6.0.2 [skip ci]
bbefdac 
## [6.0.2](karma-runner/karma@v6.0.1...v6.0.2) (2021-01-25)

### Bug Fixes

* avoid ES6+ syntax in client scripts ([karma-runner#3629](karma-runner#3629)) ([6629e96](karma-runner@6629e96)), closes [karma-runner#3630](karma-runner#3630)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jginsburgn jginsburgn jginsburgn approved these changes

@devoto13 devoto13 devoto13 approved these changes

@johnjbarton johnjbarton Awaiting requested review from johnjbarton

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@longlho @AppVeyorBot @karmarunnerbot @Trott @johnjbarton @devoto13 @jginsburgn