Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Process Launcher does not clean up sigkill timeout #946

Closed
vojtajina opened this issue Mar 11, 2014 · 0 comments · Fixed by #1054
Closed

Process Launcher does not clean up sigkill timeout #946

vojtajina opened this issue Mar 11, 2014 · 0 comments · Fixed by #1054
Assignees
@pkozlowski-opensource
Labels
help wanted type: bug
Milestone
v0.14

Comments

@vojtajina
Copy link
Contributor

When killing a browser, the sigkill timeout has to be cleared in _onProcessExit.
@vojtajina vojtajina added this to the v0.14 milestone Mar 11, 2014
@vojtajina vojtajina mentioned this issue Mar 14, 2014
Closed
@sylvain-hamel sylvain-hamel mentioned this issue Mar 14, 2014
Closed
@vojtajina vojtajina mentioned this issue Apr 23, 2014
Closed
@pkozlowski-opensource pkozlowski-opensource self-assigned this Apr 25, 2014
pkozlowski-opensource added a commit to pkozlowski-opensource/karma that referenced this issue Apr 30, 2014
@pkozlowski-opensource
fix(launcher): cancel kill timeout when process exits cleanly
e5c8456 
By default browsers are killed with `process.kill()` but it might
happen that a process doesn't play nicelly and doesn't exit so
there is a timeout after which a process is SIGKILL-ed. Before
this commit the mentioned timeout wasn't cleared on clean process
exit, preventing Karma from exiting just after all tests were run.

Fixes karma-runner#946
This was referenced Apr 30, 2014
Closed
Closed
pkozlowski-opensource added a commit to pkozlowski-opensource/karma that referenced this issue May 1, 2014
@pkozlowski-opensource
fix(launcher): cancel kill timeout when process exits cleanly
92d514c 
By default browsers are killed with `process.kill()` but it might
happen that a process doesn't play nicelly and doesn't exit so
there is a timeout after which a process is SIGKILL-ed. Before
this commit the mentioned timeout wasn't cleared on clean process
exit, preventing Karma from exiting just after all tests were run.

Fixes karma-runner#946
Merged
pkozlowski-opensource added a commit to pkozlowski-opensource/karma that referenced this issue May 8, 2014
@pkozlowski-opensource
fix(launcher): cancel kill timeout when process exits cleanly
bd66274 
By default browsers are killed with `process.kill()` but it might
happen that a process doesn't play nicelly and doesn't exit so
there is a timeout after which a process is SIGKILL-ed. Before
this commit the mentioned timeout wasn't cleared on clean process
exit, preventing Karma from exiting just after all tests were run.

Fixes karma-runner#946
This was referenced Sep 27, 2018
Merged
Closed
This was referenced May 25, 2019
Closed
Merged
@renovate renovate bot mentioned this issue Sep 28, 2019
Merged
1 task
@renovate renovate bot mentioned this issue Oct 11, 2019
Merged
1 task
@cmorell cmorell mentioned this issue Jun 3, 2020
Open
1 task
@renovate renovate bot mentioned this issue Aug 19, 2020
Closed
1 task
@renovate renovate bot mentioned this issue Apr 6, 2021
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pkozlowski-opensource pkozlowski-opensource

Labels
help wanted type: bug
Projects
None yet
Milestone
v0.14
2 participants
@vojtajina @pkozlowski-opensource