Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw an error on not found browsers #855

Closed
dcherman opened this issue Dec 10, 2013 · 8 comments · May be fixed by Omrisnyk/npm-lockfiles#122 or Omrisnyk/npm-lockfiles#132
Closed

Throw an error on not found browsers #855

dcherman opened this issue Dec 10, 2013 · 8 comments · May be fixed by Omrisnyk/npm-lockfiles#122 or Omrisnyk/npm-lockfiles#132
Assignees
@budde377
Labels
PR exists type: feature
Milestone
v1.0

Comments

@dcherman
Copy link

Currently, it looks like if a browser isn't able to be loaded, karma just warns you and happily proceeds with the browsers that could be loaded.

https://github.com/karma-runner/karma/blob/master/lib/launcher.js#L41-L46

In a CI environment, it would be really, really easy to overlook that all of the sudden one of your configured browsers isn't working anymore, but since no errors are thrown the build is still happy.

I'm proposing that instead of continuing on, encountering a browser that couldn't be loaded should be treated as a fatal error - any loaded browsers should be cleaned up, and the process should exit.
@vojtajina
Copy link
Contributor

I agree.

@vojtajina
Copy link
Contributor

missing anything should fail (cannot load):

  • plugin
  • launcher
  • reporter
  • preprocessor

Show all errors and fail (not fail on first error).

@vojtajina vojtajina modified the milestones: v0.14, v0.12 Feb 5, 2014
@sylvain-hamel
Copy link
Contributor

This is related to #1011

@vojtajina
Copy link
Contributor

@jnewman where is this error coming from? The Fatal error: ... does not look like Karma...
Btw, you should update Karma, it sounds like you are on a pretty old version.

@jnewman
Copy link

jnewman commented May 11, 2014

@vojtajina I thought the issue was related this, I was mistaken. (It's concurrent processes on our CI, but I thought the conflict was from karma; it's not.)

srawlins added a commit to srawlins/karma that referenced this issue Nov 7, 2014
@srawlins
feat: Fail on launcher-, reporter-, or preprocessor-load errors.
3e6900f 
Fail out of karma if a launcher, reporter, or preprocessor fails to
load, after attempting to load each of them, and reporting errors for
each load error.

This is a WIP: I can't quite figure out where to place a final check on
whether any errors were caught while loading launchers, reporters, or
preprocessors. Any quick tip would be much appreciated!

Closes karma-runner#855
@srawlins srawlins mentioned this issue Nov 7, 2014
Closed
@dignifiedquire dignifiedquire modified the milestones: v1.0, v0.14 May 17, 2015
srawlins added a commit to srawlins/karma that referenced this issue Jul 16, 2015
@srawlins
feat: Fail on launcher-, reporter-, or preprocessor-load errors.
73432eb 
Fail out of karma if a launcher, reporter, or preprocessor fails to
load, after attempting to load each of them, and reporting errors for
each load error.

Closes karma-runner#855
@dignifiedquire
Copy link
Member

@budde377 mind taking a look at this? This is the last thing I want to get in that isn't PRed yet before finally moving to 1.0 and using proper semver.

@dignifiedquire
Copy link
Member

@budde377 there exists a PR already that started this, but it's not finished yet: #1239

@budde377
Copy link
Member

@dignifiedquire Will do!

@budde377 budde377 self-assigned this Feb 20, 2016
budde377 pushed a commit to budde377/karma that referenced this issue Feb 23, 2016
@srawlins @budde377
feat: Fail on launcher-, reporter-, or preprocessor-load errors.
dfcba5c 
Fail out of karma if a launcher, reporter, or preprocessor fails to
load, after attempting to load each of them, and reporting errors for
each load error.

Closes karma-runner#855
budde377 pushed a commit to budde377/karma that referenced this issue Feb 23, 2016
@srawlins @budde377
feat: Fail on launcher-, reporter-, or preprocessor-load errors.
0a05504 
Fail out of karma if a launcher, reporter, or preprocessor fails to
load, after attempting to load each of them, and reporting errors for
each load error.

Closes karma-runner#855
budde377 pushed a commit to budde377/karma that referenced this issue Feb 25, 2016
@srawlins @budde377
feat: Fail on launcher-, reporter-, plugin-, or preprocessor-load err…
650d7e3 
…ors.

Stop karma if a launcher, reporter, plugin, or preprocessor fails to
load, after attempting to load each of them, and reporting errors for
each load error.

Closes karma-runner#855
budde377 pushed a commit to budde377/karma that referenced this issue Feb 25, 2016
@srawlins @budde377
feat: Fail on launcher-, reporter-, plugin-, or preprocessor-load err…
4c88429 
…ors.

Stop karma if a launcher, reporter, plugin, or preprocessor fails to
load, after attempting to load each of them, and reporting errors for
each load error.

Closes karma-runner#855
@budde377 budde377 mentioned this issue Feb 25, 2016
Merged
budde377 pushed a commit to budde377/karma that referenced this issue Feb 25, 2016
@srawlins @budde377
feat: Fail on launcher-, reporter-, plugin-, or preprocessor-load err…
21a3e46 
…ors.

Stop karma if a launcher, reporter, plugin, or preprocessor fails to
load, after attempting to load each of them, and reporting errors for
each load error.

Closes karma-runner#855
budde377 pushed a commit to budde377/karma that referenced this issue Feb 25, 2016
@srawlins @budde377
feat: Fail on launcher-, reporter-, plugin-, or preprocessor-load err…
cd24d95 
…ors.

Stop karma if a launcher, reporter, plugin, or preprocessor fails to
load, after attempting to load each of them, and reporting errors for
each load error.

Closes karma-runner#855
srawlins added a commit to srawlins/karma that referenced this issue Feb 29, 2016
@srawlins
feat: Fail on launcher-, reporter-, plugin-, or preprocessor-load err…
3903dbc 
…ors.

Stop karma if a launcher, reporter, plugin, or preprocessor fails to
load, after attempting to load each of them, and reporting errors for
each load error.

Closes karma-runner#855
@srawlins srawlins mentioned this issue Feb 29, 2016
Closed
budde377 added a commit to budde377/karma that referenced this issue Mar 1, 2016
@budde377
feat: Fail on launcher-, reporter-, plugin-, or preprocessor-load err…
dfe9943 
…ors.

Stop karma if a launcher, reporter, plugin, or preprocessor fails to
load, after attempting to load each of them, and reporting errors for
each load error.

Closes karma-runner#855
budde377 pushed a commit to budde377/karma that referenced this issue Mar 1, 2016
@srawlins @budde377
feat: Fail on launcher-, reporter-, plugin-, or preprocessor-load err…
5f96ef6 
…ors.

Stop karma if a launcher, reporter, plugin, or preprocessor fails to
load, after attempting to load each of them, and reporting errors for
each load error.

Closes karma-runner#855
budde377 pushed a commit to budde377/karma that referenced this issue Mar 1, 2016
@srawlins @budde377
feat: Fail on launcher-, reporter-, plugin-, or preprocessor-load err…
9c705a7 
…ors.

Stop karma if a launcher, reporter, plugin, or preprocessor fails to
load, after attempting to load each of them, and reporting errors for
each load error.

Closes karma-runner#855
budde377 pushed a commit to budde377/karma that referenced this issue Mar 1, 2016
@srawlins @budde377
feat: Fail on launcher-, reporter-, plugin-, or preprocessor-load err…
fca930e 
…ors.

Stop karma if a launcher, reporter, plugin, or preprocessor fails to
load, after attempting to load each of them, and reporting errors for
each load error.

Closes karma-runner#855
@Omrisnyk Omrisnyk mentioned this issue Oct 27, 2023
Open
@Omrisnyk Omrisnyk mentioned this issue Dec 15, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@budde377 budde377

Labels
PR exists type: feature
Projects
None yet
Milestone
v1.0
6 participants
@vojtajina @jnewman @dignifiedquire @dcherman @sylvain-hamel @budde377