-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Karma returns non-zero exit code with disabled failOnFailingTestSuite when all tests are failed #3367
Comments
ilgonmic
added a commit
to ilgonmic/karma
that referenced
this issue
Sep 26, 2019
- there are failOnFailingTestSuite and failOnEmptyTestSuite, so in this there is no neccesity Fixes karma-runner#3367
ilgonmic
added a commit
to ilgonmic/karma
that referenced
this issue
Oct 2, 2019
- there are failOnFailingTestSuite and failOnEmptyTestSuite, so in this there is no neccesity Fixes karma-runner#3367
johnjbarton
pushed a commit
that referenced
this issue
Oct 10, 2019
* fix(runner): remove explicit error on all tests failed - there are failOnFailingTestSuite and failOnEmptyTestSuite, so in this there is no neccesity Fixes #3367 * test(unit): Remove test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expected behaviour
exit code -
0
Actual behaviour
exit code -
1
Environment Details
Karma version (output of
karma --version
):Karma version: 4.0.1
Relevant part of your
karma.config.js
file"failOnFailingTestSuite": false
Steps to reproduce the behaviour
"failOnFailingTestSuite": false
karma start
Details
Is it consistent behaviour, if I set
failOnFailingTestSuite
(from #3116) onfalse
, but Karma returns non-zero exit code, when all my tests are failed?Seems that these lines are root cause, is it actual since we have
failOnFailingTestSuite
property?karma/lib/browser.js
Lines 90 to 92 in 6235e68
The text was updated successfully, but these errors were encountered: