Include "allow-multiple-definition" LD flag for Android ARM

[dan-turner]

Closes #34

[karalabe]

I was wondering why I didn't catch this one :) Turns out it was fixed by Go 1.6 (golang/go#9510), and since I was using that for the Android builds this slipped through. Thanks for catching it!

[karalabe]

Strange, but this doesn't seem to fix it for me currently. I get the same linker errors. (I'm trying to build master, since develop already removed the gmp).

[dan-turner]

Even after publishing the new docker image? I must confess I didn't test it
because I would have had to create my own docker images and change all the
references to it.

On Thursday, 14 January 2016, Péter Szilágyi [email protected]
wrote:

Strange, but this doesn't seem to fix it for me currently. I get the same
linker errors.

—
Reply to this email directly or view it on GitHub
#35 (comment).

[karalabe]

You need to rebuild only the base image and one of the release images to do it :)

docker build --tag karalabe/xgo-base ./docker/base
docker build --tag karalabe/xgo-1.5.3 ./docker/go-1.5.3

Then you can specify to xgo the version you require explicitly so that it doesn't require all the meta images to be built (e.g. --go=1.5.3 or GO=1.5.3 (in make)) :)

[karalabe]

Still, android builds most definitely worked well, so I screwed something up bad..

[karalabe]

Ok, I think docker screwed something up. I did a ton of rebuilds and now everything works fine. Will probably push out the images and then clean up everything and do a recheck to make sure.

[dan-turner]

Nice!

On Thursday, 14 January 2016, Péter Szilágyi [email protected]
wrote:

Ok, I think docker screwed something up. I did a ton of rebuilds and now
everything works fine. Will probably push out the images and then clean up
everything and do a recheck to make sure.

—
Reply to this email directly or view it on GitHub
#35 (comment).

[karalabe]

I've also polished this a bit so that the workaround is used only for Go 1.5 and below. Since Go 1.6 fixes the issue and android/arm64 and android/386 are only supported in Go 1.6+, there's no point in adding the workaround to these platforms. a9a3fc2