Fix go mod vendor #31
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes golang/go#26366 by adding a dummy.go file in required folders.
dolmen
reviewed
Apr 17, 2021
|
Cosmetic suggestion: use the directory name as the dummy package name. for d in $(find internal -type d); do echo "package $(basename $d)" >"$d/dummy.go"; done |
This was referenced Jan 13, 2022
dolmen
added a commit
to dolmen-go/hid
that referenced
this pull request
Feb 20, 2022
To allow 'go mod -vendor' to take directories, we create dummy packages in each directory. Basically it does: for d in $(find internal -type d); do echo "package $(basename $d)" >"$d/pkg.go"; done A script is used to maintained those dummy package besides hidapi/libusb upgrades: internal/dummy-packages.sh See: - karalabe#31 - golang/go#26366
|
Well, this doesn't fix the issue. Here is what we get with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works around golang/go#26366 by adding a
dummy.gofile in required folders. Without this fix, all C and H files will be missing from the vendor folder, causing the build to fail.For another example, see Hywan/go-ext-wasm@4724910