Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switched 'created' event for 'ready' event so that it runs after $el is inserted. #7

Merged
merged 1 commit into from
Aug 20, 2016

Conversation

MKRazz
Copy link
Contributor

@MKRazz MKRazz commented Aug 18, 2016

The video loaded fine on first load, but when we put it on a page in vue-router and navigated away/back it wouldn't load the video. I debugged it a little and found that the element with the incremented id didn't exist yet when it was trying to create the new player on that id. Switching created to ready solved the problem for us.

@MKRazz MKRazz changed the title Switched 'created' event for 'ready' event so that it runs after is … Switched 'created' event for 'ready' event so that it runs after $el is inserted. Aug 18, 2016
@kaorun343
Copy link
Owner

Thanks a lot!
I'll merge this.

@kaorun343 kaorun343 merged commit 92d4e50 into kaorun343:master Aug 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants