Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give the component the name 'YoutubeEmbed' #59

Merged
merged 1 commit into from
Jul 20, 2019

Conversation

rokkie
Copy link
Contributor

@rokkie rokkie commented Jun 14, 2019

This allows it to be selected during unit tests, otherwise something
like wrapper.findAll({ name: 'YoutubeEmbed' }) (or any other name
for that matter) will never yield anything.
Fixes #58

This allows it to be selected during unit tests, otherwise something
like `wrapper.findAll({ name: 'YoutubeEmbed' })` (or any other name
for that matter) will never yield anything.
Fixes kaorun343#58
@kaorun343
Copy link
Owner

@rokkie

I apologize you for my late reply.
Thanks for your PR.
I'll merge this.

@kaorun343 kaorun343 merged commit a4ba127 into kaorun343:master Jul 20, 2019
@rokkie rokkie deleted the bugfix/58-missing-component-name branch July 21, 2019 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing component name prevents it from being selected during unit testing
2 participants