Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(dependabot): group dockerfile updates in dependabot config #3055

Merged
merged 3 commits into from
Sep 4, 2024

Conversation

hairyhum
Copy link
Contributor

Change Overview

Directory groups were not enabled before and each dockerfile had to have separate config.
Now we can group multiple directories updates into same config and PR

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test
  • 🏗️ Build

Issues

  • fixes #issue-number

Test Plan

Wait and see what dependabot produces.

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

Directory groups were not enabled before and each dockerfile had to have separate config.
Now we can group multiple directories updates into same config
commit-message:
prefix: "deps(docker,pip):"
directories:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may still want to create a group so a single PR with all the updates gets created. I assume that is the intent.
I have not checked whether or not the directories: key/stanza works inside a group (in groups:). Please verify.

Suggested change
directories:
groups:
docker-pip:
directories:

Copy link
Contributor Author

@hairyhum hairyhum Aug 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, you can't use directories key inside the groups key. The groups key is there to select specific dependencies.
When using directories dependabot is supposed to group them in a single PR as I understand from the docs.

@hairyhum hairyhum added the kueue label Sep 4, 2024
@mergify mergify bot merged commit fe06a7f into master Sep 4, 2024
18 checks passed
@mergify mergify bot deleted the dependabot-docker-group branch September 4, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants