Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 0 digit being blanked incorrectly #185

Merged
merged 1 commit into from
Oct 8, 2019
Merged

Fix 0 digit being blanked incorrectly #185

merged 1 commit into from
Oct 8, 2019

Conversation

Xenoamor
Copy link
Contributor

@Xenoamor Xenoamor commented Oct 7, 2019

As found in #184

@kohrar
Copy link
Contributor

kohrar commented Oct 7, 2019

Thanks for looking into this bug! I wasn't quite sure how the logic actually worked and didn't have the time to figure it out.

I'll give it a try tonight.

@Xenoamor
Copy link
Contributor Author

Xenoamor commented Oct 7, 2019

Thanks! Yeah I wrote this section and on a second look it appeared to be wrong

@kohrar
Copy link
Contributor

kohrar commented Oct 8, 2019

Seems to fix the issue for me. Great job!

@kanflo kanflo merged commit 633ae99 into kanflo:master Oct 8, 2019
@kohrar kohrar mentioned this pull request Oct 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Xenoamor @kohrar @kanflo