Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configures the Access-Control-Allow-Credentials CORS header #5189

Conversation

rickbijkerk
Copy link
Contributor

@rickbijkerk rickbijkerk commented Jul 10, 2024

Background

Configures the Access-Control-Allow-Credentials CORS header

Description

allows credentials to be used in requests

We ran into an issue after updating Hive, our cors preflight request got redirected to our SSO page due to missing cookies. This should fix that and allow us to update

Copy link

changeset-bot bot commented Jul 10, 2024

⚠️ No Changeset found

Latest commit: 54fe3b0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kamilkisiela kamilkisiela changed the base branch from main to pr-5189 July 15, 2024 06:31
@kamilkisiela kamilkisiela deleted the branch kamilkisiela:pr-5189 July 15, 2024 06:57
@kamilkisiela
Copy link
Owner

Oppsie :D I referenced your PR in my other PR to test the change and it got closed

kamilkisiela added a commit that referenced this pull request Jul 15, 2024
Aallows credentials to be used in requests

We ran into an issue after updating Hive, our cors preflight request got redirected to our SSO page due to missing cookies. This should fix that and allow us to update

Continues #5189
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants