[laboratory] scroll to operation in collections' accordion on first load #5000

dimaMachina · 2024-06-19T14:03:17Z

scroll to operation in collections' accordion on the first load
There is a bug when sometimes, the right collection is not opened on the first load with searchParams operation, fixed by using value instead defaultValue in <Accordion /> element

Screen.Recording.2024-06-19.at.15.47.25.mov

changeset-bot · 2024-06-19T14:03:22Z

⚠️ No Changeset found

Latest commit: a2b2ffd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

dimaMachina · 2024-06-19T14:04:28Z

packages/web/app/src/pages/target-laboratory.tsx

@@ -1100,6 +1110,7 @@ function LaboratoryPageContent(props: {
 visiblePlugin={operationCollectionsPlugin}
 schema={schema}
 forcedTheme="dark"
+ disableTabs


use new feature instead

github-actions · 2024-06-19T14:05:59Z

📚 Storybook Deployment

The latest changes are available as preview in: https://54cc7ced.hive-storybook.pages.dev

github-actions · 2024-06-19T14:09:46Z

🐋 This PR was built and pushed to the following Docker images (tag: a2b2ffdff4aff1cc3ea58e76eba2fc4f1491ff75):

Docker Bake metadata

{
"app": {
  "buildx.build.ref": "builder-cbcb2db3-eb38-4408-8bd4-c41695af9382/builder-cbcb2db3-eb38-4408-8bd4-c41695af93820/aqa08xctegk3jw184jdogcqd7",
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
    "digest": "sha256:75487f9d71c939788cc9e8d5eb590f1498d975ab6b8772fa417d9e2842a3d75a",
    "size": 685
  },
  "containerimage.digest": "sha256:75487f9d71c939788cc9e8d5eb590f1498d975ab6b8772fa417d9e2842a3d75a",
  "image.name": "ghcr.io/kamilkisiela/graphql-hive/app:a2b2ffdff4aff1cc3ea58e76eba2fc4f1491ff75,ghcr.io/kamilkisiela/graphql-hive/app:scroll_on_first_load_for_operation"
},
"composition-federation-2": {
  "buildx.build.ref": "builder-cbcb2db3-eb38-4408-8bd4-c41695af9382/builder-cbcb2db3-eb38-4408-8bd4-c41695af93820/2ewjea7s5kodmolip86p5fu7q",
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
    "digest": "sha256:03244c2a78a6df311ec1cb3cf5752dc5a4d79585607709ad527fa3debf344db5",
    "size": 685
  },
  "containerimage.digest": "sha256:03244c2a78a6df311ec1cb3cf5752dc5a4d79585607709ad527fa3debf344db5",
  "image.name": "ghcr.io/kamilkisiela/graphql-hive/composition-federation-2:a2b2ffdff4aff1cc3ea58e76eba2fc4f1491ff75,ghcr.io/kamilkisiela/graphql-hive/composition-federation-2:scroll_on_first_load_for_operation"
},
"emails": {
  "buildx.build.ref": "builder-cbcb2db3-eb38-4408-8bd4-c41695af9382/builder-cbcb2db3-eb38-4408-8bd4-c41695af93820/n4kwvqe6impe0zhvolijmm9jb",
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
    "digest": "sha256:22f75cd69697a4a0a88d685fba8faa3284848a802bf4b9178b3a70780c9714a0",
    "size": 685
  },
  "containerimage.digest": "sha256:22f75cd69697a4a0a88d685fba8faa3284848a802bf4b9178b3a70780c9714a0",
  "image.name": "ghcr.io/kamilkisiela/graphql-hive/emails:a2b2ffdff4aff1cc3ea58e76eba2fc4f1491ff75,ghcr.io/kamilkisiela/graphql-hive/emails:scroll_on_first_load_for_operation"
},
"policy": {
  "buildx.build.ref": "builder-cbcb2db3-eb38-4408-8bd4-c41695af9382/builder-cbcb2db3-eb38-4408-8bd4-c41695af93820/owri3p0sn2yyyv8g41661skut",
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
    "digest": "sha256:e68dfdda16792f47fe50d44dcfb71f565a93c984aef43787dd598263344fe871",
    "size": 685
  },
  "containerimage.digest": "sha256:e68dfdda16792f47fe50d44dcfb71f565a93c984aef43787dd598263344fe871",
  "image.name": "ghcr.io/kamilkisiela/graphql-hive/policy:a2b2ffdff4aff1cc3ea58e76eba2fc4f1491ff75,ghcr.io/kamilkisiela/graphql-hive/policy:scroll_on_first_load_for_operation"
},
"rate-limit": {
  "buildx.build.ref": "builder-cbcb2db3-eb38-4408-8bd4-c41695af9382/builder-cbcb2db3-eb38-4408-8bd4-c41695af93820/g5bn2pf0ii8gxxxmx0t1pecmb",
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
    "digest": "sha256:43c8bba4efa90fda2ce0639999937a70232697fdc68fc9ca20a2e355f2e00362",
    "size": 685
  },
  "containerimage.digest": "sha256:43c8bba4efa90fda2ce0639999937a70232697fdc68fc9ca20a2e355f2e00362",
  "image.name": "ghcr.io/kamilkisiela/graphql-hive/rate-limit:a2b2ffdff4aff1cc3ea58e76eba2fc4f1491ff75,ghcr.io/kamilkisiela/graphql-hive/rate-limit:scroll_on_first_load_for_operation"
},
"schema": {
  "buildx.build.ref": "builder-cbcb2db3-eb38-4408-8bd4-c41695af9382/builder-cbcb2db3-eb38-4408-8bd4-c41695af93820/yjj9s3jphmyvj3gjrt1ua9v8b",
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
    "digest": "sha256:d25e3dfd425cdb29842463b6fbf133e8ff04d2e2ee9de332c0673e33dfbc4dea",
    "size": 685
  },
  "containerimage.digest": "sha256:d25e3dfd425cdb29842463b6fbf133e8ff04d2e2ee9de332c0673e33dfbc4dea",
  "image.name": "ghcr.io/kamilkisiela/graphql-hive/schema:a2b2ffdff4aff1cc3ea58e76eba2fc4f1491ff75,ghcr.io/kamilkisiela/graphql-hive/schema:scroll_on_first_load_for_operation"
},
"server": {
  "buildx.build.ref": "builder-cbcb2db3-eb38-4408-8bd4-c41695af9382/builder-cbcb2db3-eb38-4408-8bd4-c41695af93820/g8ecds936wd2l2qedyonl5td8",
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
    "digest": "sha256:7daf8c6efc3325df3420a741ca280185589d5e2108c045e3647585629eb3a2a7",
    "size": 685
  },
  "containerimage.digest": "sha256:7daf8c6efc3325df3420a741ca280185589d5e2108c045e3647585629eb3a2a7",
  "image.name": "ghcr.io/kamilkisiela/graphql-hive/server:a2b2ffdff4aff1cc3ea58e76eba2fc4f1491ff75,ghcr.io/kamilkisiela/graphql-hive/server:scroll_on_first_load_for_operation"
},
"storage": {
  "buildx.build.ref": "builder-cbcb2db3-eb38-4408-8bd4-c41695af9382/builder-cbcb2db3-eb38-4408-8bd4-c41695af93820/ydt6adu289ivyhdrih9918e40",
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
    "digest": "sha256:b12abf4af0d59fcf832088c13e1561aa24022cacb4d04ddc1d12b5db029b60f1",
    "size": 685
  },
  "containerimage.digest": "sha256:b12abf4af0d59fcf832088c13e1561aa24022cacb4d04ddc1d12b5db029b60f1",
  "image.name": "ghcr.io/kamilkisiela/graphql-hive/storage:a2b2ffdff4aff1cc3ea58e76eba2fc4f1491ff75,ghcr.io/kamilkisiela/graphql-hive/storage:scroll_on_first_load_for_operation"
},
"stripe-billing": {
  "buildx.build.ref": "builder-cbcb2db3-eb38-4408-8bd4-c41695af9382/builder-cbcb2db3-eb38-4408-8bd4-c41695af93820/0hbr8ohuk00sdsmri076rhmi3",
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
    "digest": "sha256:ad7ecb8f87602c4de629e2aaf23626008fd0f9bf69dbf8efcd57f371453f6b13",
    "size": 685
  },
  "containerimage.digest": "sha256:ad7ecb8f87602c4de629e2aaf23626008fd0f9bf69dbf8efcd57f371453f6b13",
  "image.name": "ghcr.io/kamilkisiela/graphql-hive/stripe-billing:a2b2ffdff4aff1cc3ea58e76eba2fc4f1491ff75,ghcr.io/kamilkisiela/graphql-hive/stripe-billing:scroll_on_first_load_for_operation"
},
"tokens": {
  "buildx.build.ref": "builder-cbcb2db3-eb38-4408-8bd4-c41695af9382/builder-cbcb2db3-eb38-4408-8bd4-c41695af93820/ar96osibsxq22qmx4dy4hktmv",
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
    "digest": "sha256:ef8f88e27d511cb34fdc746012fe40ebfdbf57e0e91d9383e176c476f6075307",
    "size": 685
  },
  "containerimage.digest": "sha256:ef8f88e27d511cb34fdc746012fe40ebfdbf57e0e91d9383e176c476f6075307",
  "image.name": "ghcr.io/kamilkisiela/graphql-hive/tokens:a2b2ffdff4aff1cc3ea58e76eba2fc4f1491ff75,ghcr.io/kamilkisiela/graphql-hive/tokens:scroll_on_first_load_for_operation"
},
"usage": {
  "buildx.build.ref": "builder-cbcb2db3-eb38-4408-8bd4-c41695af9382/builder-cbcb2db3-eb38-4408-8bd4-c41695af93820/3qd5gosy9jzs2yq2c0c8f99fa",
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
    "digest": "sha256:6639728999412cee05312b41ec7c7779dae9ff001c71ba3d6167b21b82ccdf5d",
    "size": 685
  },
  "containerimage.digest": "sha256:6639728999412cee05312b41ec7c7779dae9ff001c71ba3d6167b21b82ccdf5d",
  "image.name": "ghcr.io/kamilkisiela/graphql-hive/usage:a2b2ffdff4aff1cc3ea58e76eba2fc4f1491ff75,ghcr.io/kamilkisiela/graphql-hive/usage:scroll_on_first_load_for_operation"
},
"usage-estimator": {
  "buildx.build.ref": "builder-cbcb2db3-eb38-4408-8bd4-c41695af9382/builder-cbcb2db3-eb38-4408-8bd4-c41695af93820/lv4hh53ej9gllblwrmvupwc45",
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
    "digest": "sha256:507c5b6d6955c05734657447604b73e98d54a8784cc098a05f181e354109e60a",
    "size": 685
  },
  "containerimage.digest": "sha256:507c5b6d6955c05734657447604b73e98d54a8784cc098a05f181e354109e60a",
  "image.name": "ghcr.io/kamilkisiela/graphql-hive/usage-estimator:a2b2ffdff4aff1cc3ea58e76eba2fc4f1491ff75,ghcr.io/kamilkisiela/graphql-hive/usage-estimator:scroll_on_first_load_for_operation"
},
"usage-ingestor": {
  "buildx.build.ref": "builder-cbcb2db3-eb38-4408-8bd4-c41695af9382/builder-cbcb2db3-eb38-4408-8bd4-c41695af93820/dqa15u229ocmh21fi2zvo0eyl",
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
    "digest": "sha256:245d42708cad68aac8c6994f2c8ae85f00bb4c53eb06030c69a543f2fc627ea0",
    "size": 685
  },
  "containerimage.digest": "sha256:245d42708cad68aac8c6994f2c8ae85f00bb4c53eb06030c69a543f2fc627ea0",
  "image.name": "ghcr.io/kamilkisiela/graphql-hive/usage-ingestor:a2b2ffdff4aff1cc3ea58e76eba2fc4f1491ff75,ghcr.io/kamilkisiela/graphql-hive/usage-ingestor:scroll_on_first_load_for_operation"
},
"webhooks": {
  "buildx.build.ref": "builder-cbcb2db3-eb38-4408-8bd4-c41695af9382/builder-cbcb2db3-eb38-4408-8bd4-c41695af93820/wcl45dop3sm61g4jytfu79gao",
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
    "digest": "sha256:87501b55474c4592275fb1b1c2f525039d4fa68c9da3a9f40d2c03a00f587c3a",
    "size": 685
  },
  "containerimage.digest": "sha256:87501b55474c4592275fb1b1c2f525039d4fa68c9da3a9f40d2c03a00f587c3a",
  "image.name": "ghcr.io/kamilkisiela/graphql-hive/webhooks:a2b2ffdff4aff1cc3ea58e76eba2fc4f1491ff75,ghcr.io/kamilkisiela/graphql-hive/webhooks:scroll_on_first_load_for_operation"
}
}

kamilkisiela · 2024-06-24T08:38:07Z

@dimaMachina can you resolve merge conflicts? After that, you can merge.

fix typecheck fix stuff use css variables for defining height

…oad (#5000)

dimaMachina commented Jun 19, 2024

View reviewed changes

dimaMachina mentioned this pull request Jun 20, 2024

[laboratory] make GraphiQL resizable to full viewport size #4994

Merged

n1ru4l approved these changes Jun 20, 2024

View reviewed changes

Base automatically changed from move-prettier-button to dima-lab-umbrella June 24, 2024 08:35

kamilkisiela force-pushed the dima-lab-umbrella branch from 0ae1ee3 to b8fc4ac Compare June 24, 2024 09:01

dimaMachina force-pushed the scroll-on-first-load-for-operation branch from ebb2585 to 8c908fb Compare June 24, 2024 11:15

aaa

aea4fcd

fix typecheck fix stuff use css variables for defining height

dimaMachina force-pushed the scroll-on-first-load-for-operation branch from 8c908fb to aea4fcd Compare June 24, 2024 11:19

use align-items: center; for GraphiQL header

a2b2ffd

dimaMachina merged commit a151765 into dima-lab-umbrella Jun 24, 2024
18 checks passed

dimaMachina deleted the scroll-on-first-load-for-operation branch June 24, 2024 11:33

dimaMachina mentioned this pull request Jun 24, 2024

Laboratory improvements - umbrella PR #4989

Merged

kamilkisiela pushed a commit that referenced this pull request Jun 24, 2024

[laboratory] scroll to operation in collections' accordion on first l…

9b97024

…oad (#5000)

kamilkisiela pushed a commit that referenced this pull request Jun 25, 2024

[laboratory] scroll to operation in collections' accordion on first l…

bcd1b27

…oad (#5000)

kamilkisiela pushed a commit that referenced this pull request Jun 25, 2024

[laboratory] scroll to operation in collections' accordion on first l…

988aa23

…oad (#5000)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[laboratory] scroll to operation in collections' accordion on first load #5000

[laboratory] scroll to operation in collections' accordion on first load #5000

dimaMachina commented Jun 19, 2024

changeset-bot bot commented Jun 19, 2024 •

edited

Loading

dimaMachina Jun 19, 2024

github-actions bot commented Jun 19, 2024 •

edited

Loading

github-actions bot commented Jun 19, 2024 •

edited

Loading

kamilkisiela commented Jun 24, 2024

[laboratory] scroll to operation in collections' accordion on first load #5000

[laboratory] scroll to operation in collections' accordion on first load #5000

Conversation

dimaMachina commented Jun 19, 2024

changeset-bot bot commented Jun 19, 2024 • edited Loading

⚠️ No Changeset found

dimaMachina Jun 19, 2024

Choose a reason for hiding this comment

github-actions bot commented Jun 19, 2024 • edited Loading

📚 Storybook Deployment

github-actions bot commented Jun 19, 2024 • edited Loading

kamilkisiela commented Jun 24, 2024

changeset-bot bot commented Jun 19, 2024 •

edited

Loading

github-actions bot commented Jun 19, 2024 •

edited

Loading

github-actions bot commented Jun 19, 2024 •

edited

Loading