Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[laboratory] hide Share Operation GraphiQL toolbar button if operation is not yet saved #4995

Merged

Conversation

dimaMachina
Copy link
Collaborator

@dimaMachina dimaMachina commented Jun 18, 2024

nothing happens if an operation is not saved

previous experience is:

340739953-ca2dd07a-50ec-4746-9ef4-926b38b46df0.mov

Copy link

changeset-bot bot commented Jun 18, 2024

⚠️ No Changeset found

Latest commit: 14bad0b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

📚 Storybook Deployment

The latest changes are available as preview in: https://19e9ebd4.hive-storybook.pages.dev

Copy link
Contributor

🐋 This PR was built and pushed to the following Docker images (tag: 14bad0be834b2dd6139c1e280406aeb45d487d01):

Docker Bake metadata
{
"app": {
  "buildx.build.ref": "builder-7537efb1-3cdd-4c4d-b060-75d8079ab862/builder-7537efb1-3cdd-4c4d-b060-75d8079ab8620/g3bmlvcxnq2m5ye6mprkuzybs",
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
    "digest": "sha256:b4864648cbc9c2c74fbb2ae2f8e9427c7f5e81bfad3301bf90b266895878557d",
    "size": 685
  },
  "containerimage.digest": "sha256:b4864648cbc9c2c74fbb2ae2f8e9427c7f5e81bfad3301bf90b266895878557d",
  "image.name": "ghcr.io/kamilkisiela/graphql-hive/app:14bad0be834b2dd6139c1e280406aeb45d487d01,ghcr.io/kamilkisiela/graphql-hive/app:hide_share_button_if_operation_is_not_saved"
},
"composition-federation-2": {
  "buildx.build.ref": "builder-7537efb1-3cdd-4c4d-b060-75d8079ab862/builder-7537efb1-3cdd-4c4d-b060-75d8079ab8620/wvh9yj7ydr2stgr3mpj77gl3n",
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
    "digest": "sha256:0fddd0ae81360e2a149abd7edc59d584020977a292829499b98f29dfc9a910d5",
    "size": 685
  },
  "containerimage.digest": "sha256:0fddd0ae81360e2a149abd7edc59d584020977a292829499b98f29dfc9a910d5",
  "image.name": "ghcr.io/kamilkisiela/graphql-hive/composition-federation-2:14bad0be834b2dd6139c1e280406aeb45d487d01,ghcr.io/kamilkisiela/graphql-hive/composition-federation-2:hide_share_button_if_operation_is_not_saved"
},
"emails": {
  "buildx.build.ref": "builder-7537efb1-3cdd-4c4d-b060-75d8079ab862/builder-7537efb1-3cdd-4c4d-b060-75d8079ab8620/vh1l95p75anrwgsj5k20trxxt",
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
    "digest": "sha256:f33a98c5cae93ec6a4c53e211afa4ddf918545fa407a9682c83040ffe561bc6f",
    "size": 685
  },
  "containerimage.digest": "sha256:f33a98c5cae93ec6a4c53e211afa4ddf918545fa407a9682c83040ffe561bc6f",
  "image.name": "ghcr.io/kamilkisiela/graphql-hive/emails:14bad0be834b2dd6139c1e280406aeb45d487d01,ghcr.io/kamilkisiela/graphql-hive/emails:hide_share_button_if_operation_is_not_saved"
},
"policy": {
  "buildx.build.ref": "builder-7537efb1-3cdd-4c4d-b060-75d8079ab862/builder-7537efb1-3cdd-4c4d-b060-75d8079ab8620/rudq3tmou5vcx264u094412ue",
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
    "digest": "sha256:1451c7c91b36147b7b969b904f017b5bcfeab79d43e21b7bf2e25b1fba712d7a",
    "size": 685
  },
  "containerimage.digest": "sha256:1451c7c91b36147b7b969b904f017b5bcfeab79d43e21b7bf2e25b1fba712d7a",
  "image.name": "ghcr.io/kamilkisiela/graphql-hive/policy:14bad0be834b2dd6139c1e280406aeb45d487d01,ghcr.io/kamilkisiela/graphql-hive/policy:hide_share_button_if_operation_is_not_saved"
},
"rate-limit": {
  "buildx.build.ref": "builder-7537efb1-3cdd-4c4d-b060-75d8079ab862/builder-7537efb1-3cdd-4c4d-b060-75d8079ab8620/isbqnqwkcbumz4sxldocy1e17",
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
    "digest": "sha256:645ab130044471adf5a875c01f53ff79a72df0bff83fb4b7321015697067fe9e",
    "size": 685
  },
  "containerimage.digest": "sha256:645ab130044471adf5a875c01f53ff79a72df0bff83fb4b7321015697067fe9e",
  "image.name": "ghcr.io/kamilkisiela/graphql-hive/rate-limit:14bad0be834b2dd6139c1e280406aeb45d487d01,ghcr.io/kamilkisiela/graphql-hive/rate-limit:hide_share_button_if_operation_is_not_saved"
},
"schema": {
  "buildx.build.ref": "builder-7537efb1-3cdd-4c4d-b060-75d8079ab862/builder-7537efb1-3cdd-4c4d-b060-75d8079ab8620/wsap2d7k71dskk3rz4p4mfcdb",
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
    "digest": "sha256:88f8631337ab343256a207c5705f57808832eb475a6a87c87f0dbaa892d0a777",
    "size": 685
  },
  "containerimage.digest": "sha256:88f8631337ab343256a207c5705f57808832eb475a6a87c87f0dbaa892d0a777",
  "image.name": "ghcr.io/kamilkisiela/graphql-hive/schema:14bad0be834b2dd6139c1e280406aeb45d487d01,ghcr.io/kamilkisiela/graphql-hive/schema:hide_share_button_if_operation_is_not_saved"
},
"server": {
  "buildx.build.ref": "builder-7537efb1-3cdd-4c4d-b060-75d8079ab862/builder-7537efb1-3cdd-4c4d-b060-75d8079ab8620/jcpitaxsfn153yzx16yz3n5aa",
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
    "digest": "sha256:2adce6ba1b359092055ec22f6be1891b8ad634e02639a7dd42403ec959f1fb97",
    "size": 685
  },
  "containerimage.digest": "sha256:2adce6ba1b359092055ec22f6be1891b8ad634e02639a7dd42403ec959f1fb97",
  "image.name": "ghcr.io/kamilkisiela/graphql-hive/server:14bad0be834b2dd6139c1e280406aeb45d487d01,ghcr.io/kamilkisiela/graphql-hive/server:hide_share_button_if_operation_is_not_saved"
},
"storage": {
  "buildx.build.ref": "builder-7537efb1-3cdd-4c4d-b060-75d8079ab862/builder-7537efb1-3cdd-4c4d-b060-75d8079ab8620/r13i46b96u285pbl7fpgl0zcg",
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
    "digest": "sha256:a15de311a706c4e437e7709c175625dcfba34fbc6eeb708626cd6443c827ac5e",
    "size": 685
  },
  "containerimage.digest": "sha256:a15de311a706c4e437e7709c175625dcfba34fbc6eeb708626cd6443c827ac5e",
  "image.name": "ghcr.io/kamilkisiela/graphql-hive/storage:14bad0be834b2dd6139c1e280406aeb45d487d01,ghcr.io/kamilkisiela/graphql-hive/storage:hide_share_button_if_operation_is_not_saved"
},
"stripe-billing": {
  "buildx.build.ref": "builder-7537efb1-3cdd-4c4d-b060-75d8079ab862/builder-7537efb1-3cdd-4c4d-b060-75d8079ab8620/be56pvpph4076lfeynpihsjtu",
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
    "digest": "sha256:6092b30bd7f4b5ea740e7ea4881fe00309a26faa2a0a771c685262e21ad88410",
    "size": 685
  },
  "containerimage.digest": "sha256:6092b30bd7f4b5ea740e7ea4881fe00309a26faa2a0a771c685262e21ad88410",
  "image.name": "ghcr.io/kamilkisiela/graphql-hive/stripe-billing:14bad0be834b2dd6139c1e280406aeb45d487d01,ghcr.io/kamilkisiela/graphql-hive/stripe-billing:hide_share_button_if_operation_is_not_saved"
},
"tokens": {
  "buildx.build.ref": "builder-7537efb1-3cdd-4c4d-b060-75d8079ab862/builder-7537efb1-3cdd-4c4d-b060-75d8079ab8620/oxivsumzrjp5hor0520p7dl2u",
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
    "digest": "sha256:41e1812d18a9a1899e0289e250bcd07bfd476dbad39e1de37f8310f3797afac8",
    "size": 685
  },
  "containerimage.digest": "sha256:41e1812d18a9a1899e0289e250bcd07bfd476dbad39e1de37f8310f3797afac8",
  "image.name": "ghcr.io/kamilkisiela/graphql-hive/tokens:14bad0be834b2dd6139c1e280406aeb45d487d01,ghcr.io/kamilkisiela/graphql-hive/tokens:hide_share_button_if_operation_is_not_saved"
},
"usage": {
  "buildx.build.ref": "builder-7537efb1-3cdd-4c4d-b060-75d8079ab862/builder-7537efb1-3cdd-4c4d-b060-75d8079ab8620/h5nl8yvze4p083m5az6399pxv",
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
    "digest": "sha256:24b4bbb0726be410e5e097025d0ff05b0ea135cd075163cf64fe85ff20d31b6a",
    "size": 685
  },
  "containerimage.digest": "sha256:24b4bbb0726be410e5e097025d0ff05b0ea135cd075163cf64fe85ff20d31b6a",
  "image.name": "ghcr.io/kamilkisiela/graphql-hive/usage:14bad0be834b2dd6139c1e280406aeb45d487d01,ghcr.io/kamilkisiela/graphql-hive/usage:hide_share_button_if_operation_is_not_saved"
},
"usage-estimator": {
  "buildx.build.ref": "builder-7537efb1-3cdd-4c4d-b060-75d8079ab862/builder-7537efb1-3cdd-4c4d-b060-75d8079ab8620/nc4stvbdtos4moy7togsaz7v6",
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
    "digest": "sha256:b00a15290a260b844589d28957eff5e824e3daa4032a961361cb09a9dedc9bca",
    "size": 685
  },
  "containerimage.digest": "sha256:b00a15290a260b844589d28957eff5e824e3daa4032a961361cb09a9dedc9bca",
  "image.name": "ghcr.io/kamilkisiela/graphql-hive/usage-estimator:14bad0be834b2dd6139c1e280406aeb45d487d01,ghcr.io/kamilkisiela/graphql-hive/usage-estimator:hide_share_button_if_operation_is_not_saved"
},
"usage-ingestor": {
  "buildx.build.ref": "builder-7537efb1-3cdd-4c4d-b060-75d8079ab862/builder-7537efb1-3cdd-4c4d-b060-75d8079ab8620/4kp6aust3rszbk2xutz5pfv2v",
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
    "digest": "sha256:6d9967a3de514ed69862333e3509e284c46adc28c525b897eb02e4d3024518d0",
    "size": 685
  },
  "containerimage.digest": "sha256:6d9967a3de514ed69862333e3509e284c46adc28c525b897eb02e4d3024518d0",
  "image.name": "ghcr.io/kamilkisiela/graphql-hive/usage-ingestor:14bad0be834b2dd6139c1e280406aeb45d487d01,ghcr.io/kamilkisiela/graphql-hive/usage-ingestor:hide_share_button_if_operation_is_not_saved"
},
"webhooks": {
  "buildx.build.ref": "builder-7537efb1-3cdd-4c4d-b060-75d8079ab862/builder-7537efb1-3cdd-4c4d-b060-75d8079ab8620/x7bndltq33xvxb9mx7t7llppa",
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
    "digest": "sha256:bdf7bcd40db58a53f55eb5fd9379d9dd99c2f6c6b404fa5587e76bb765d73755",
    "size": 685
  },
  "containerimage.digest": "sha256:bdf7bcd40db58a53f55eb5fd9379d9dd99c2f6c6b404fa5587e76bb765d73755",
  "image.name": "ghcr.io/kamilkisiela/graphql-hive/webhooks:14bad0be834b2dd6139c1e280406aeb45d487d01,ghcr.io/kamilkisiela/graphql-hive/webhooks:hide_share_button_if_operation_is_not_saved"
}
}

Base automatically changed from resizable-graphiql to dima-lab-umbrella June 24, 2024 08:32
@kamilkisiela kamilkisiela merged commit 8b827c4 into dima-lab-umbrella Jun 24, 2024
25 checks passed
@kamilkisiela kamilkisiela deleted the hide-share-button-if-operation-is-not-saved branch June 24, 2024 08:33
kamilkisiela pushed a commit that referenced this pull request Jun 24, 2024
kamilkisiela pushed a commit that referenced this pull request Jun 24, 2024
kamilkisiela pushed a commit that referenced this pull request Jun 25, 2024
kamilkisiela pushed a commit that referenced this pull request Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants