-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hive/app] use asChild
in <UserMenu />
whenever possible to have less DOM elements
#4984
Conversation
|
📚 Storybook DeploymentThe latest changes are available as preview in: https://adf91a2e.hive-storybook.pages.dev |
🐋 This PR was built and pushed to the following Docker images (tag: Docker Bake metadata{
"app": {
"buildx.build.ref": "builder-26151ecb-805a-4001-9131-80225abf6830/builder-26151ecb-805a-4001-9131-80225abf68300/nxezmqyd9xtcvw6xacptzg991",
"containerimage.descriptor": {
"mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
"digest": "sha256:482595001a5c8bdf6bd75d95403599f061ab7e4f691dccfce0403308c15ebff7",
"size": 685
},
"containerimage.digest": "sha256:482595001a5c8bdf6bd75d95403599f061ab7e4f691dccfce0403308c15ebff7",
"image.name": "ghcr.io/kamilkisiela/graphql-hive/app:a9bfb8ac4db0af06da5f35eb4eb8f65409c9d4bb,ghcr.io/kamilkisiela/graphql-hive/app:user_menu_as_child"
},
"composition-federation-2": {
"buildx.build.ref": "builder-26151ecb-805a-4001-9131-80225abf6830/builder-26151ecb-805a-4001-9131-80225abf68300/l9m5wttf2tgg2ldete26wsr71",
"containerimage.descriptor": {
"mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
"digest": "sha256:749edba8960c7a611921b24663a9e0ace6ef6de6382bf915e8d7dc9f9ca82c28",
"size": 685
},
"containerimage.digest": "sha256:749edba8960c7a611921b24663a9e0ace6ef6de6382bf915e8d7dc9f9ca82c28",
"image.name": "ghcr.io/kamilkisiela/graphql-hive/composition-federation-2:a9bfb8ac4db0af06da5f35eb4eb8f65409c9d4bb,ghcr.io/kamilkisiela/graphql-hive/composition-federation-2:user_menu_as_child"
},
"emails": {
"buildx.build.ref": "builder-26151ecb-805a-4001-9131-80225abf6830/builder-26151ecb-805a-4001-9131-80225abf68300/tobk9496rt6mwd1wpaktm1vsr",
"containerimage.descriptor": {
"mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
"digest": "sha256:71e99303df23e9b94b72e65510fbdd1f9e0479a996f105926df45f277d52c289",
"size": 685
},
"containerimage.digest": "sha256:71e99303df23e9b94b72e65510fbdd1f9e0479a996f105926df45f277d52c289",
"image.name": "ghcr.io/kamilkisiela/graphql-hive/emails:a9bfb8ac4db0af06da5f35eb4eb8f65409c9d4bb,ghcr.io/kamilkisiela/graphql-hive/emails:user_menu_as_child"
},
"policy": {
"buildx.build.ref": "builder-26151ecb-805a-4001-9131-80225abf6830/builder-26151ecb-805a-4001-9131-80225abf68300/gfsx3tdvagc9bu6e33bq7mi5p",
"containerimage.descriptor": {
"mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
"digest": "sha256:957d6db5049ebbed3e4c920551eb02a9359462b284d670ac78ef0c3ba84f3809",
"size": 685
},
"containerimage.digest": "sha256:957d6db5049ebbed3e4c920551eb02a9359462b284d670ac78ef0c3ba84f3809",
"image.name": "ghcr.io/kamilkisiela/graphql-hive/policy:a9bfb8ac4db0af06da5f35eb4eb8f65409c9d4bb,ghcr.io/kamilkisiela/graphql-hive/policy:user_menu_as_child"
},
"rate-limit": {
"buildx.build.ref": "builder-26151ecb-805a-4001-9131-80225abf6830/builder-26151ecb-805a-4001-9131-80225abf68300/ebter6v0257ls3719nw4lrz9b",
"containerimage.descriptor": {
"mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
"digest": "sha256:73319cf267e93d40a54cca46662e7a6f55a85f4511ecc9a2cac8b8f3afc80593",
"size": 685
},
"containerimage.digest": "sha256:73319cf267e93d40a54cca46662e7a6f55a85f4511ecc9a2cac8b8f3afc80593",
"image.name": "ghcr.io/kamilkisiela/graphql-hive/rate-limit:a9bfb8ac4db0af06da5f35eb4eb8f65409c9d4bb,ghcr.io/kamilkisiela/graphql-hive/rate-limit:user_menu_as_child"
},
"schema": {
"buildx.build.ref": "builder-26151ecb-805a-4001-9131-80225abf6830/builder-26151ecb-805a-4001-9131-80225abf68300/ouu5dmqme1tasri5ra761wkhw",
"containerimage.descriptor": {
"mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
"digest": "sha256:336b12a7138f66552eab806e9bb89e52767e6db1dac5c319424c3ac6569e034c",
"size": 685
},
"containerimage.digest": "sha256:336b12a7138f66552eab806e9bb89e52767e6db1dac5c319424c3ac6569e034c",
"image.name": "ghcr.io/kamilkisiela/graphql-hive/schema:a9bfb8ac4db0af06da5f35eb4eb8f65409c9d4bb,ghcr.io/kamilkisiela/graphql-hive/schema:user_menu_as_child"
},
"server": {
"buildx.build.ref": "builder-26151ecb-805a-4001-9131-80225abf6830/builder-26151ecb-805a-4001-9131-80225abf68300/z40lqygtntlru0i265a1fyu35",
"containerimage.descriptor": {
"mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
"digest": "sha256:d417bf6a7fab94ed6bf599fb37d64c1e75d24ad77460efe01faabb08576ff2da",
"size": 685
},
"containerimage.digest": "sha256:d417bf6a7fab94ed6bf599fb37d64c1e75d24ad77460efe01faabb08576ff2da",
"image.name": "ghcr.io/kamilkisiela/graphql-hive/server:a9bfb8ac4db0af06da5f35eb4eb8f65409c9d4bb,ghcr.io/kamilkisiela/graphql-hive/server:user_menu_as_child"
},
"storage": {
"buildx.build.ref": "builder-26151ecb-805a-4001-9131-80225abf6830/builder-26151ecb-805a-4001-9131-80225abf68300/o0ty29mx23dle4y7d0tpwdflq",
"containerimage.descriptor": {
"mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
"digest": "sha256:4cc087f16b1c1d3575b42f6dbf1ac580c0809b9ebd49b62b869e89348611265f",
"size": 685
},
"containerimage.digest": "sha256:4cc087f16b1c1d3575b42f6dbf1ac580c0809b9ebd49b62b869e89348611265f",
"image.name": "ghcr.io/kamilkisiela/graphql-hive/storage:a9bfb8ac4db0af06da5f35eb4eb8f65409c9d4bb,ghcr.io/kamilkisiela/graphql-hive/storage:user_menu_as_child"
},
"stripe-billing": {
"buildx.build.ref": "builder-26151ecb-805a-4001-9131-80225abf6830/builder-26151ecb-805a-4001-9131-80225abf68300/pi30rgjz9ow2dm4ix158rb54u",
"containerimage.descriptor": {
"mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
"digest": "sha256:27022c74709ff6558263ec32e9d70f870ff345dc8864fceb62bcad8129d80e2b",
"size": 685
},
"containerimage.digest": "sha256:27022c74709ff6558263ec32e9d70f870ff345dc8864fceb62bcad8129d80e2b",
"image.name": "ghcr.io/kamilkisiela/graphql-hive/stripe-billing:a9bfb8ac4db0af06da5f35eb4eb8f65409c9d4bb,ghcr.io/kamilkisiela/graphql-hive/stripe-billing:user_menu_as_child"
},
"tokens": {
"buildx.build.ref": "builder-26151ecb-805a-4001-9131-80225abf6830/builder-26151ecb-805a-4001-9131-80225abf68300/qaveshn2e4fnfwom50zd0odkc",
"containerimage.descriptor": {
"mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
"digest": "sha256:8a4ef0e33e790050ec5dd38d6d8bb26a802ab84aa8dd3bb1fd5937b7ee6bb58b",
"size": 685
},
"containerimage.digest": "sha256:8a4ef0e33e790050ec5dd38d6d8bb26a802ab84aa8dd3bb1fd5937b7ee6bb58b",
"image.name": "ghcr.io/kamilkisiela/graphql-hive/tokens:a9bfb8ac4db0af06da5f35eb4eb8f65409c9d4bb,ghcr.io/kamilkisiela/graphql-hive/tokens:user_menu_as_child"
},
"usage": {
"buildx.build.ref": "builder-26151ecb-805a-4001-9131-80225abf6830/builder-26151ecb-805a-4001-9131-80225abf68300/n0le0gfmnu3555mwo0u91aelv",
"containerimage.descriptor": {
"mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
"digest": "sha256:cc7cd16abea8d7dec9364bdc2d44de6f31cf62789364ccc997b3970e0a16dcd7",
"size": 685
},
"containerimage.digest": "sha256:cc7cd16abea8d7dec9364bdc2d44de6f31cf62789364ccc997b3970e0a16dcd7",
"image.name": "ghcr.io/kamilkisiela/graphql-hive/usage:a9bfb8ac4db0af06da5f35eb4eb8f65409c9d4bb,ghcr.io/kamilkisiela/graphql-hive/usage:user_menu_as_child"
},
"usage-estimator": {
"buildx.build.ref": "builder-26151ecb-805a-4001-9131-80225abf6830/builder-26151ecb-805a-4001-9131-80225abf68300/568lxtyl23b1pqm390rkufs54",
"containerimage.descriptor": {
"mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
"digest": "sha256:ff4defce15dce107bb7b02e044ddd93f874491dd446ba4044e8e25128ca0bc4d",
"size": 685
},
"containerimage.digest": "sha256:ff4defce15dce107bb7b02e044ddd93f874491dd446ba4044e8e25128ca0bc4d",
"image.name": "ghcr.io/kamilkisiela/graphql-hive/usage-estimator:a9bfb8ac4db0af06da5f35eb4eb8f65409c9d4bb,ghcr.io/kamilkisiela/graphql-hive/usage-estimator:user_menu_as_child"
},
"usage-ingestor": {
"buildx.build.ref": "builder-26151ecb-805a-4001-9131-80225abf6830/builder-26151ecb-805a-4001-9131-80225abf68300/xwctxivqy2k84elm0psqygbn8",
"containerimage.descriptor": {
"mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
"digest": "sha256:3bc16e13f6952e1728d066e6f14b63415ec0ec18a7138397ebce31b9a0902c8b",
"size": 685
},
"containerimage.digest": "sha256:3bc16e13f6952e1728d066e6f14b63415ec0ec18a7138397ebce31b9a0902c8b",
"image.name": "ghcr.io/kamilkisiela/graphql-hive/usage-ingestor:a9bfb8ac4db0af06da5f35eb4eb8f65409c9d4bb,ghcr.io/kamilkisiela/graphql-hive/usage-ingestor:user_menu_as_child"
},
"webhooks": {
"buildx.build.ref": "builder-26151ecb-805a-4001-9131-80225abf6830/builder-26151ecb-805a-4001-9131-80225abf68300/va04v4umxrq1jq5d77cl5c3x6",
"containerimage.descriptor": {
"mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
"digest": "sha256:7bca79cbd9b972cba67cd9223d946ff332e66ae05b273d0053a9195dbcf35d04",
"size": 685
},
"containerimage.digest": "sha256:7bca79cbd9b972cba67cd9223d946ff332e66ae05b273d0053a9195dbcf35d04",
"image.name": "ghcr.io/kamilkisiela/graphql-hive/webhooks:a9bfb8ac4db0af06da5f35eb4eb8f65409c9d4bb,ghcr.io/kamilkisiela/graphql-hive/webhooks:user_menu_as_child"
}
} |
No description provided.