Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[eslint] disallow duplicate unions #4962

Closed
wants to merge 4 commits into from
Closed

[eslint] disallow duplicate unions #4962

wants to merge 4 commits into from

Conversation

dimaMachina
Copy link
Collaborator

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 12, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: d9a2353

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dimaMachina dimaMachina changed the title disallow duplicate unions [eslint] disallow duplicate unions Jun 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 12, 2024 •
edited
Loading

🐋 This PR was built and pushed to the following Docker images (tag: d9a23536bb6d11c7f884ed0f1628150eba89ee9f):

Docker Bake metadata 
{
"app": {
  "buildx.build.ref": "builder-5868b333-0503-463a-9892-b484a7762a8d/builder-5868b333-0503-463a-9892-b484a7762a8d0/tsrh2ofo1nb243sjp28f7rox5",
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
    "digest": "sha256:c04c5dfb8d77839d12989caef2a7743b312c8a68569d3b19e73aa6bdfcc18955",
    "size": 685
  },
  "containerimage.digest": "sha256:c04c5dfb8d77839d12989caef2a7743b312c8a68569d3b19e73aa6bdfcc18955",
  "image.name": "ghcr.io/kamilkisiela/graphql-hive/app:d9a23536bb6d11c7f884ed0f1628150eba89ee9f,ghcr.io/kamilkisiela/graphql-hive/app:disallow_duplicate_unions"
},
"composition-federation-2": {
  "buildx.build.ref": "builder-5868b333-0503-463a-9892-b484a7762a8d/builder-5868b333-0503-463a-9892-b484a7762a8d0/2khllagcsdcwpyihts4uckbc0",
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
    "digest": "sha256:58049b4596b237d336e4e0132f52b1542dccaffa52fdf76aad94d779e8acaa68",
    "size": 685
  },
  "containerimage.digest": "sha256:58049b4596b237d336e4e0132f52b1542dccaffa52fdf76aad94d779e8acaa68",
  "image.name": "ghcr.io/kamilkisiela/graphql-hive/composition-federation-2:d9a23536bb6d11c7f884ed0f1628150eba89ee9f,ghcr.io/kamilkisiela/graphql-hive/composition-federation-2:disallow_duplicate_unions"
},
"emails": {
  "buildx.build.ref": "builder-5868b333-0503-463a-9892-b484a7762a8d/builder-5868b333-0503-463a-9892-b484a7762a8d0/f1ih3pyweg7jjof6bkuxk20gd",
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
    "digest": "sha256:b0b5f7a579434164a2e8c936187e10aa41f33ff3c9dc3b707a5b53b858b4008c",
    "size": 685
  },
  "containerimage.digest": "sha256:b0b5f7a579434164a2e8c936187e10aa41f33ff3c9dc3b707a5b53b858b4008c",
  "image.name": "ghcr.io/kamilkisiela/graphql-hive/emails:d9a23536bb6d11c7f884ed0f1628150eba89ee9f,ghcr.io/kamilkisiela/graphql-hive/emails:disallow_duplicate_unions"
},
"policy": {
  "buildx.build.ref": "builder-5868b333-0503-463a-9892-b484a7762a8d/builder-5868b333-0503-463a-9892-b484a7762a8d0/45trh75hsgtmtz4dul3fg1aul",
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
    "digest": "sha256:430b635911e0a76f3dee9d87c8f834b490cac2af99976fc0e392fef689cd9c60",
    "size": 685
  },
  "containerimage.digest": "sha256:430b635911e0a76f3dee9d87c8f834b490cac2af99976fc0e392fef689cd9c60",
  "image.name": "ghcr.io/kamilkisiela/graphql-hive/policy:d9a23536bb6d11c7f884ed0f1628150eba89ee9f,ghcr.io/kamilkisiela/graphql-hive/policy:disallow_duplicate_unions"
},
"rate-limit": {
  "buildx.build.ref": "builder-5868b333-0503-463a-9892-b484a7762a8d/builder-5868b333-0503-463a-9892-b484a7762a8d0/e2k9y95q0g6xk0agkkvspboc0",
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
    "digest": "sha256:5d5a7f9f100a3f85c1c3ce515434d6e6b4747376d99d212106240e7e47d2e332",
    "size": 685
  },
  "containerimage.digest": "sha256:5d5a7f9f100a3f85c1c3ce515434d6e6b4747376d99d212106240e7e47d2e332",
  "image.name": "ghcr.io/kamilkisiela/graphql-hive/rate-limit:d9a23536bb6d11c7f884ed0f1628150eba89ee9f,ghcr.io/kamilkisiela/graphql-hive/rate-limit:disallow_duplicate_unions"
},
"schema": {
  "buildx.build.ref": "builder-5868b333-0503-463a-9892-b484a7762a8d/builder-5868b333-0503-463a-9892-b484a7762a8d0/towkstmy8ya5pv0uno0s45phq",
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
    "digest": "sha256:8449a88cb9c9bca6d8be6ea8c9e4e435268471e295b4e772cc654552b1333f76",
    "size": 685
  },
  "containerimage.digest": "sha256:8449a88cb9c9bca6d8be6ea8c9e4e435268471e295b4e772cc654552b1333f76",
  "image.name": "ghcr.io/kamilkisiela/graphql-hive/schema:d9a23536bb6d11c7f884ed0f1628150eba89ee9f,ghcr.io/kamilkisiela/graphql-hive/schema:disallow_duplicate_unions"
},
"server": {
  "buildx.build.ref": "builder-5868b333-0503-463a-9892-b484a7762a8d/builder-5868b333-0503-463a-9892-b484a7762a8d0/1mv0mzmigbrshq0qwhfwhiu6s",
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
    "digest": "sha256:c92553a4bd9102bb55d84ccefd4a4b73628fc400d2421f735054782638f359e5",
    "size": 685
  },
  "containerimage.digest": "sha256:c92553a4bd9102bb55d84ccefd4a4b73628fc400d2421f735054782638f359e5",
  "image.name": "ghcr.io/kamilkisiela/graphql-hive/server:d9a23536bb6d11c7f884ed0f1628150eba89ee9f,ghcr.io/kamilkisiela/graphql-hive/server:disallow_duplicate_unions"
},
"storage": {
  "buildx.build.ref": "builder-5868b333-0503-463a-9892-b484a7762a8d/builder-5868b333-0503-463a-9892-b484a7762a8d0/ssqz67fwelkja7eip2sd5dxj1",
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
    "digest": "sha256:95749f7db8d6c922eca8af2277294e981d8546008d552632b0e5bc4efae0e700",
    "size": 685
  },
  "containerimage.digest": "sha256:95749f7db8d6c922eca8af2277294e981d8546008d552632b0e5bc4efae0e700",
  "image.name": "ghcr.io/kamilkisiela/graphql-hive/storage:d9a23536bb6d11c7f884ed0f1628150eba89ee9f,ghcr.io/kamilkisiela/graphql-hive/storage:disallow_duplicate_unions"
},
"stripe-billing": {
  "buildx.build.ref": "builder-5868b333-0503-463a-9892-b484a7762a8d/builder-5868b333-0503-463a-9892-b484a7762a8d0/8d566ss56zxsffhfzoltno0si",
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
    "digest": "sha256:7dedffe4415146313f8d92b561a263d55b4cc21e42d82b6575b63753ef55a922",
    "size": 685
  },
  "containerimage.digest": "sha256:7dedffe4415146313f8d92b561a263d55b4cc21e42d82b6575b63753ef55a922",
  "image.name": "ghcr.io/kamilkisiela/graphql-hive/stripe-billing:d9a23536bb6d11c7f884ed0f1628150eba89ee9f,ghcr.io/kamilkisiela/graphql-hive/stripe-billing:disallow_duplicate_unions"
},
"tokens": {
  "buildx.build.ref": "builder-5868b333-0503-463a-9892-b484a7762a8d/builder-5868b333-0503-463a-9892-b484a7762a8d0/dqqe2jnrolv0uw8jxfikfzik2",
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
    "digest": "sha256:eae2ed3087b95549dec909354c9fdcb3472ca302bdba02762b08586c0b3181aa",
    "size": 685
  },
  "containerimage.digest": "sha256:eae2ed3087b95549dec909354c9fdcb3472ca302bdba02762b08586c0b3181aa",
  "image.name": "ghcr.io/kamilkisiela/graphql-hive/tokens:d9a23536bb6d11c7f884ed0f1628150eba89ee9f,ghcr.io/kamilkisiela/graphql-hive/tokens:disallow_duplicate_unions"
},
"usage": {
  "buildx.build.ref": "builder-5868b333-0503-463a-9892-b484a7762a8d/builder-5868b333-0503-463a-9892-b484a7762a8d0/mvgqvq10oimea0msfe9c288rp",
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
    "digest": "sha256:80568d2d24170062637d049e9fddae5130d8c58ee63a6cf1bf3bd30654f8fd93",
    "size": 685
  },
  "containerimage.digest": "sha256:80568d2d24170062637d049e9fddae5130d8c58ee63a6cf1bf3bd30654f8fd93",
  "image.name": "ghcr.io/kamilkisiela/graphql-hive/usage:d9a23536bb6d11c7f884ed0f1628150eba89ee9f,ghcr.io/kamilkisiela/graphql-hive/usage:disallow_duplicate_unions"
},
"usage-estimator": {
  "buildx.build.ref": "builder-5868b333-0503-463a-9892-b484a7762a8d/builder-5868b333-0503-463a-9892-b484a7762a8d0/jxwuuo4m2r6temt73a087fn3t",
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
    "digest": "sha256:c4c35696fa9802340f115e10138ad850fcb4ea99895f7298785272da874fbb23",
    "size": 685
  },
  "containerimage.digest": "sha256:c4c35696fa9802340f115e10138ad850fcb4ea99895f7298785272da874fbb23",
  "image.name": "ghcr.io/kamilkisiela/graphql-hive/usage-estimator:d9a23536bb6d11c7f884ed0f1628150eba89ee9f,ghcr.io/kamilkisiela/graphql-hive/usage-estimator:disallow_duplicate_unions"
},
"usage-ingestor": {
  "buildx.build.ref": "builder-5868b333-0503-463a-9892-b484a7762a8d/builder-5868b333-0503-463a-9892-b484a7762a8d0/rc6x561kv6blyptyce5bn5ay1",
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
    "digest": "sha256:7ff40de1e3a41c35d9324427dd3ec63dc4889523b0caa592c54523eb4cd13ff1",
    "size": 685
  },
  "containerimage.digest": "sha256:7ff40de1e3a41c35d9324427dd3ec63dc4889523b0caa592c54523eb4cd13ff1",
  "image.name": "ghcr.io/kamilkisiela/graphql-hive/usage-ingestor:d9a23536bb6d11c7f884ed0f1628150eba89ee9f,ghcr.io/kamilkisiela/graphql-hive/usage-ingestor:disallow_duplicate_unions"
},
"webhooks": {
  "buildx.build.ref": "builder-5868b333-0503-463a-9892-b484a7762a8d/builder-5868b333-0503-463a-9892-b484a7762a8d0/dzq1etxxhy3njn2o9bb7511mp",
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
    "digest": "sha256:59a5b58ad72c5fe31be0048d64305a00eef1fb8def814e05fb5c21b795c6a1c0",
    "size": 685
  },
  "containerimage.digest": "sha256:59a5b58ad72c5fe31be0048d64305a00eef1fb8def814e05fb5c21b795c6a1c0",
  "image.name": "ghcr.io/kamilkisiela/graphql-hive/webhooks:d9a23536bb6d11c7f884ed0f1628150eba89ee9f,ghcr.io/kamilkisiela/graphql-hive/webhooks:disallow_duplicate_unions"
}
}

kamilkisiela
kamilkisiela reviewed Jun 14, 2024
View reviewed changes
.eslintrc.cjs
@@ -95,6 +96,7 @@ module.exports = {
plugins: [...guildConfig.plugins, 'hive'],
extends: guildConfig.extends,
rules: {
'@typescript-eslint/no-duplicate-type-constituents': 'error',
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'@typescript-eslint/no-duplicate-type-constituents': 'error',

@kamilkisiela
Copy link
Owner

I don't think we should eslint integration tests

@kamilkisiela kamilkisiela deleted the disallow-duplicate-unions branch July 10, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamilkisiela kamilkisiela kamilkisiela left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dimaMachina @kamilkisiela