Skip to content
This repository has been archived by the owner on Apr 22, 2021. It is now read-only.

Fix Spammer doesn't support cyrillic symbols #825

Merged
merged 4 commits into from May 15, 2020
Merged

Fix Spammer doesn't support cyrillic symbols #825

merged 4 commits into from May 15, 2020

Conversation

ghost
Copy link

@ghost ghost commented May 13, 2020

#766


name: issue #766
about: Fix for issue #766

@5HT2 5HT2 added this to the v1.1.4 milestone May 13, 2020
@5HT2 5HT2 linked an issue May 13, 2020 that may be closed by this pull request
@5HT2
Copy link
Member

5HT2 commented May 13, 2020

Would you mind making these changes for LoginMessage and ChatFilter? @suretic

@5HT2 5HT2 added the --review-pending Pending a review of the pull label May 13, 2020
@ghost
Copy link
Author

ghost commented May 13, 2020

sure

@5HT2
Copy link
Member

5HT2 commented May 13, 2020

thanks!

@ghost
Copy link
Author

ghost commented May 13, 2020

https://prnt.sc/sgbspz
Is LoginMessage supposed to be working? When I try to connect to a server I get this error with and without my changes

@5HT2
Copy link
Member

5HT2 commented May 13, 2020

What's the log? Honestly open a new bug report tbh

@ghost
Copy link
Author

ghost commented May 13, 2020

Error executing task
java.util.concurrent.ExecutionException: java.lang.NullPointerException
at java.util.concurrent.FutureTask.report(FutureTask.java:122)
at java.util.concurrent.FutureTask.get(FutureTask.java:192)
at net.minecraft.util.Util.func_181617_a(Util.java:48)
at net.minecraft.client.Minecraft.func_71411_J(Minecraft.java:1087)
at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:397)
at net.minecraft.client.main.Main.main(SourceFile:123)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:497)
at net.minecraft.launchwrapper.Launch.launch(Launch.java:135)
at net.minecraft.launchwrapper.Launch.main(Launch.java:28)
Caused by: java.lang.NullPointerException
at net.minecraft.client.network.NetHandlerPlayClient.func_147282_a(NetHandlerPlayClient.java:298)
at net.minecraft.network.play.server.SPacketJoinGame.func_148833_a(SourceFile:76)
at net.minecraft.network.play.server.SPacketJoinGame.func_148833_a(SourceFile:13)
at net.minecraft.network.PacketThreadUtil$1.run(PacketThreadUtil.java:20)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at net.minecraft.util.Util.func_181617_a(Util.java:47)
... 9 more
00:53:31.074
Error executing task
java.util.concurrent.ExecutionException: java.lang.NullPointerException
at java.util.concurrent.FutureTask.report(FutureTask.java:122)
at java.util.concurrent.FutureTask.get(FutureTask.java:192)
at net.minecraft.util.Util.func_181617_a(Util.java:48)
at net.minecraft.client.Minecraft.func_71411_J(Minecraft.java:1087)
at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:397)
at net.minecraft.client.main.Main.main(SourceFile:123)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:497)
at net.minecraft.launchwrapper.Launch.launch(Launch.java:135)
at net.minecraft.launchwrapper.Launch.main(Launch.java:28)
Caused by: java.lang.NullPointerException
at net.minecraft.client.network.NetHandlerPlayClient.func_147240_a(NetHandlerPlayClient.java:1876)
at net.minecraft.network.play.server.SPacketCustomPayload.func_148833_a(SPacketCustomPayload.java:58)
at net.minecraft.network.play.server.SPacketCustomPayload.func_148833_a(SPacketCustomPayload.java:11)
at net.minecraft.network.PacketThreadUtil$1.run(PacketThreadUtil.java:20)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at net.minecraft.util.Util.func_181617_a(Util.java:47)
... 9 more
00:53:31.075
Error executing task
java.util.concurrent.ExecutionException: java.lang.NullPointerException
at java.util.concurrent.FutureTask.report(FutureTask.java:122)
at java.util.concurrent.FutureTask.get(FutureTask.java:192)
at net.minecraft.util.Util.func_181617_a(Util.java:48)
at net.minecraft.client.Minecraft.func_71411_J(Minecraft.java:1087)
at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:397)
at net.minecraft.client.main.Main.main(SourceFile:123)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:497)
at net.minecraft.launchwrapper.Launch.launch(Launch.java:135)
at net.minecraft.launchwrapper.Launch.main(Launch.java:28)
Caused by: java.lang.NullPointerException
at net.minecraft.client.network.NetHandlerPlayClient.func_175101_a(NetHandlerPlayClient.java:1532)
at net.minecraft.network.play.server.SPacketServerDifficulty.func_148833_a(SourceFile:25)
at net.minecraft.network.play.server.SPacketServerDifficulty.func_148833_a(SourceFile:9)
at net.minecraft.network.PacketThreadUtil$1.run(PacketThreadUtil.java:20)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at net.minecraft.util.Util.func_181617_a(Util.java:47)
... 9 more

@5HT2
Copy link
Member

5HT2 commented May 13, 2020

Make a bug report

@5HT2 5HT2 changed the title https://github.com/kami-blue/client/issues/766 Fix Spammer doesn't support cyrillic symbols May 14, 2020
@5HT2 5HT2 added --testing-pending Pending testing of the pull and removed --review-pending Pending a review of the pull labels May 14, 2020
@5HT2 5HT2 merged commit 73a365b into kami-blue:master May 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
--testing-pending Pending testing of the pull -module bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spammer doesn't support cyrillic symbols
1 participant