Skip to content
This repository has been archived by the owner on Apr 22, 2021. It is now read-only.

[enhancement] Add a modified setting command. #1925

Merged
merged 8 commits into from
Feb 14, 2021
Merged

[enhancement] Add a modified setting command. #1925

merged 8 commits into from
Feb 14, 2021

Conversation

scorbett123
Copy link
Contributor

Adds a modified setting command that allows for easier debugging and easy resetting of changes.

Just click to reset.

@5HT2
Copy link
Member

5HT2 commented Feb 9, 2021

I'd much rather the modified settings suggestion from #1648 be implemented instead, as the majority of people likely don't use the chat commands and using something like this is a bit ehhh

@5HT2 5HT2 added --info-requested Further information is requested enhancement -gui labels Feb 9, 2021
@5HT2 5HT2 added this to the 2.03.01 milestone Feb 9, 2021
@scorbett123
Copy link
Contributor Author

I think that the suggestion in #1648 is good, however I was more thinking of this as a power user thing, and I especially like it due to having previously messed up the gui, but didn't was to reset everything to defaults. But your call. If you want I can try and combine this and that.

This would also be useful in some cases when people are asking for help, and gives people the ability to set a single setting to default.

@5HT2
Copy link
Member

5HT2 commented Feb 9, 2021

Ohh this one is on a per setting basis?

@scorbett123
Copy link
Contributor Author

Yes, when doing it you can see which settings you have changed and reset them individually. (just by clicking on them)

@scorbett123
Copy link
Contributor Author

I think my wording in it is a bit dodgy, so if you have a better idea of how to word it please say.

@scorbett123
Copy link
Contributor Author

This branch now also has boldness on modified settings. As you mentioned earlier @L1ving

@5HT2
Copy link
Member

5HT2 commented Feb 9, 2021

Is that optional? Just throw a setting in ClickGui if it isn't

@scorbett123
Copy link
Contributor Author

Yep, it is optional.

Signed-off-by: scorbett123 <[email protected]>
Signed-off-by: scorbett123 <[email protected]>
Signed-off-by: scorbett123 <[email protected]>
@5HT2 5HT2 added --changes-requested Changes need to be made to the pull and removed --info-requested Further information is requested labels Feb 11, 2021
Signed-off-by: scorbett123 <[email protected]>
Signed-off-by: scorbett123 <[email protected]>
Signed-off-by: scorbett123 <[email protected]>
@5HT2 5HT2 added --testing-pending Pending testing of the pull and removed --changes-requested Changes need to be made to the pull labels Feb 14, 2021
@5HT2 5HT2 merged commit 2eb6105 into kami-blue:master Feb 14, 2021
@5HT2
Copy link
Member

5HT2 commented Feb 14, 2021

Thanks!

@scorbett123
Copy link
Contributor Author

Thanks

@scorbett123 scorbett123 deleted the modifiedSettings branch March 26, 2021 11:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
--testing-pending Pending testing of the pull -gui enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants