This repository has been archived by the owner on Apr 22, 2021. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 378
[feature] AutoOffHand adjustable delay #1919
Merged
5HT2
merged 5 commits into
kami-blue:master
from
nopjmp:enhancement/autooffhand-adjustable-delay
Feb 11, 2021
Merged
[feature] AutoOffHand adjustable delay #1919
5HT2
merged 5 commits into
kami-blue:master
from
nopjmp:enhancement/autooffhand-adjustable-delay
Feb 11, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The move packet delayed is also tied to this and now runs half a tick faster since I moved the TickTimer to TICK units.
nopjmp
changed the title
Enhancement/autooffhand adjustable delay
AutoOffHand adjustable delay
Feb 7, 2021
5HT2
reviewed
Feb 7, 2021
src/main/kotlin/org/kamiblue/client/module/modules/combat/AutoOffhand.kt
Outdated
Show resolved
Hide resolved
5HT2
suggested changes
Feb 8, 2021
src/main/kotlin/org/kamiblue/client/module/modules/combat/AutoOffhand.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/org/kamiblue/client/module/modules/combat/AutoOffhand.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/org/kamiblue/client/module/modules/combat/AutoOffhand.kt
Outdated
Show resolved
Hide resolved
5HT2
approved these changes
Feb 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me, pending testing
Luna5ama
added
--testing-pending
Pending testing of the pull
and removed
--changes-requested
Changes need to be made to the pull
labels
Feb 9, 2021
5HT2
changed the title
AutoOffHand adjustable delay
[feature] AutoOffHand adjustable delay
Feb 11, 2021
Thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows tuning AutoOffhand to switch faster if the servers allow for it.
The move packet delayed is also tied to this and now runs half a tick faster since I moved the TickTimer to TICK units.