This repository has been archived by the owner on Apr 22, 2021. It is now read-only.
[enhancement] Holding "LMENU" aka Alt can now use a separate step value #1888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, this does cause a bit of a UX problem where the number jumps around if ALT is released and then the mouse moves. Another possibility would be to check for ALT when the drag starts and switch step values then.
That was an issue before your pull, don't worry |
5HT2
approved these changes
Jan 29, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull
Currently, this does cause a bit of a UX problem where the number jumps around if ALT is released and then the mouse moves.
Another possibility would be to check for ALT when the drag starts and switch step values then.
A clear and concise description of what the pull is for.
Describe how this pull is helpful
Improves the lives of the users when the step value is too large and they want to fine tune some settings
Additional context
Scott#6969 ran into this for the AntiAFK module, which is why AntiAFK has it first.