Modified ResizeOutputLayer method in nnet-nnet.cc

[vijayaditya]

Modified ResizeOutputLayer method in nnet-nnet.cc to accommodate networks with FixedScaleComponents

[jtrmal]

I applied the patch. Vijay, thanks for it

Git complained about the trailing whitespaces:

src/7.patch:83: trailing whitespace.
has_fixed_scale_component = true;
src/7.patch:87: trailing whitespace.

src/7.patch:108: trailing whitespace.

warning: 3 lines add whitespace errors.

IIRC, those are against the google style as well. Could you please revise
the patch? If you can, run cpplint.py on it just to make sure there are not
other issues...
While you are on it, I'll run the recipe to see if that solves the issues.
y.

On Wed, Jul 22, 2015 at 2:33 AM, Vijayaditya Peddinti <
[email protected]> wrote:

Modified ResizeOutputLayer method in nnet-nnet.cc to accommodate networks

with FixedScaleComponents

You can view, comment on, or merge this pull request online at:

#7
Commit Summary

• Modified ResizeOutputLayer method in nnet-nnet.cc to accommodate
  networks with FixedScaleComponents

File Changes

• M src/nnet2/nnet-component.cc
  https://github.com/kaldi-asr/kaldi/pull/7/files#diff-0 (14)
• M src/nnet2/nnet-component.h
  https://github.com/kaldi-asr/kaldi/pull/7/files#diff-1 (3)
• M src/nnet2/nnet-nnet.cc
  https://github.com/kaldi-asr/kaldi/pull/7/files#diff-2 (35)

Patch Links:

• https://github.com/kaldi-asr/kaldi/pull/7.patch
• https://github.com/kaldi-asr/kaldi/pull/7.diff

—
Reply to this email directly or view it on GitHub
#7.

[jtrmal]

Vijay, I think there is missing either

this->SetIndexes();

before you call this->Check(); or SetIndex() on the new_ac component.
y.

On Wed, Jul 22, 2015 at 8:59 AM, Jan Trmal [email protected] wrote:

I applied the patch. Vijay, thanks for it

Git complained about the trailing whitespaces:

src/7.patch:83: trailing whitespace.
has_fixed_scale_component = true;
src/7.patch:87: trailing whitespace.

src/7.patch:108: trailing whitespace.

warning: 3 lines add whitespace errors.

IIRC, those are against the google style as well. Could you please revise
the patch? If you can, run cpplint.py on it just to make sure there are not
other issues...
While you are on it, I'll run the recipe to see if that solves the issues.
y.

On Wed, Jul 22, 2015 at 2:33 AM, Vijayaditya Peddinti <
[email protected]> wrote:

Modified ResizeOutputLayer method in nnet-nnet.cc to accommodate networks

with FixedScaleComponents

You can view, comment on, or merge this pull request online at:

#7
Commit Summary

• Modified ResizeOutputLayer method in nnet-nnet.cc to accommodate
  networks with FixedScaleComponents

File Changes

• M src/nnet2/nnet-component.cc
  https://github.com/kaldi-asr/kaldi/pull/7/files#diff-0 (14)
• M src/nnet2/nnet-component.h
  https://github.com/kaldi-asr/kaldi/pull/7/files#diff-1 (3)
• M src/nnet2/nnet-nnet.cc
  https://github.com/kaldi-asr/kaldi/pull/7/files#diff-2 (35)

Patch Links:

• https://github.com/kaldi-asr/kaldi/pull/7.patch
• https://github.com/kaldi-asr/kaldi/pull/7.diff

—
Reply to this email directly or view it on GitHub
#7.