Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed -Wreordered warnings in feat #3090

Merged
merged 9 commits into from
Mar 12, 2019
Merged

Fixed -Wreordered warnings in feat #3090

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
04c2636
[feat] RecyclingVector for optional memory saving
Feb 15, 2019
fdaa42b
[feat] more detailed error message
Feb 15, 2019
51afea6
[feat] fix memory leak
Feb 15, 2019
ce4f98c
[feat] test for RecyclingVector
Feb 18, 2019
16fb501
[feat] Addressed code review
Mar 6, 2019
cd90dd3
Merge remote-tracking branch 'upstream/master'
Mar 6, 2019
ada3ca5
[feat] Fix after resolving conflicts
Mar 6, 2019
217f94e
[feat] Fix -Wreordered warnings
Mar 12, 2019
b89c5b9
Merge remote-tracking branch 'upstream/master'
Mar 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[feat] more detailed error message
  • Loading branch information
Piotr Żelasko committed Feb 15, 2019
commit fdaa42bf31c8730a24f24aac93773969d99cb74d
4 changes: 3 additions & 1 deletion src/feat/online-feature.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,9 @@ RecyclingVector::~RecyclingVector() {
Vector<BaseFloat> *RecyclingVector::Retrieve(int index) const {
if (index < first_available_index_) {
KALDI_ERR << "Attempted to retrieve feature vector that was "
"already removed by the RecyclingVector";
"already removed by the RecyclingVector (index = " << index << "; "
<< "first_available_index = " << first_available_index_ << "; "
<< "size = " << Size() << ")";
}
// 'at' does size checking.
return items_.at(index - first_available_index_);
Expand Down