Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small update to ivector-plda-scoring-dense #2991

Merged
merged 5 commits into from
Jan 16, 2019
Merged

Small update to ivector-plda-scoring-dense #2991

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b73f1b6
[egs] minor fixes related to python2 vs python3 differences
Jan 8, 2019
00cc525
[egs] fixing more syntax errors introduced in PR #2925
Jan 11, 2019
8104f56
Merge branch 'master' of https://github.com/kaldi-asr/kaldi into mino…
Jan 11, 2019
3536b5a
[src] modifying ivector-plda-scoring-dense so that if target-energy=1…
Jan 15, 2019
830d3ad
Merge branch 'master' of https://github.com/kaldi-asr/kaldi into ivec…
Jan 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 12 additions & 4 deletions src/ivectorbin/ivector-plda-scoring-dense.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,14 @@
namespace kaldi {

bool EstPca(const Matrix<BaseFloat> &ivector_mat, BaseFloat target_energy,
Matrix<BaseFloat> *mat) {
const std::string &reco, Matrix<BaseFloat> *mat) {

// If the target_energy is 1.0, it's equivalent to not applying the
// conversation-dependent PCA at all, so it's better to exit this
// function before doing any computation.
if (ApproxEqual(target_energy, 1.0, 0.001))
return false;

int32 num_rows = ivector_mat.NumRows(),
num_cols = ivector_mat.NumCols();
Vector<BaseFloat> sum;
Expand All @@ -50,6 +57,8 @@ bool EstPca(const Matrix<BaseFloat> &ivector_mat, BaseFloat target_energy,
else
Matrix<BaseFloat>(sumsq).Svd(&s, &P, NULL);
} catch (...) {
KALDI_WARN << "Unable to compute conversation dependent PCA for"
<< " recording " << reco << ".";
return false;
}

Expand Down Expand Up @@ -181,7 +190,7 @@ int main(int argc, char *argv[]) {
for (size_t i = 0; i < ivectors.size(); i++) {
ivector_mat.Row(i).CopyFromVec(ivectors[i]);
}
if (EstPca(ivector_mat, target_energy, &pca_transform)) {
if (EstPca(ivector_mat, target_energy, reco, &pca_transform)) {
// Apply the PCA transform to the raw i-vectors.
ApplyPca(ivector_mat, pca_transform, &ivector_mat_pca);

Expand All @@ -192,8 +201,7 @@ int main(int argc, char *argv[]) {
TransformIvectors(ivector_mat_pca, plda_config, this_plda,
&ivector_mat_plda);
} else {
KALDI_WARN << "Unable to compute conversation dependent PCA for"
<< " recording " << reco << ".";
// If EstPca returns false, we won't apply any PCA.
TransformIvectors(ivector_mat, plda_config, this_plda,
&ivector_mat_plda);
}
Expand Down