Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dark mode #511

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

Conversation

AnceretMatthieu
Copy link

This pull request add a dark mode to this theme (like in my fork, we can see a demo on my blog).

Note :

  • I change blue link color by orange (it makes better on dark background). If you want, i can make it configurable.
  • I add a toggle to switch between light and dark mode (by default, set to dark). If you want, i can make default mode configurable and add the possibility to disable/hide the toggle.
  • All colors are in src\scss\utils\mixins_themed.scss file. The system is designed to allow the addition of additional mode.

If you have questions or feedback I'm happy to discuss.

Matthieu.

@kakawait kakawait added the enhancement New feature or request label Sep 7, 2021
@kakawait kakawait added this to the 0.6.0-BETA milestone Sep 7, 2021
@kakawait
Copy link
Owner

kakawait commented Sep 7, 2021

Thank you so much. As discussed I'll review as soon I'll come back.

Plan for 0.6.0, just have to finish 0.5.2 but is patch version should not affect / conflict with your PR

@kakawait
Copy link
Owner

kakawait commented Oct 6, 2021

Globally is nice.

I've some small changes to do but I'll merge on develop then will fix upon develop

What I'd like to changes:

  • Put script outside head_end.html, head_end.html is a hook to let end user customize head.html it must stay "blank"
  • Some pieces of coding styles

For CSS there is too much changes I can't compile that on my head haha. I'll see more on live

AnceretMatthieu and others added 5 commits October 26, 2021 07:54
* Création d'un composant toggle permet de basculer entre les thèmes dark/light
* Intégration du toggle dans la sidebar
* Masquage de la modal "About me" via la touche échap
* Ajustement du thème pour gérer les composants en mode dark
* Ajustements sur les pages archives/tags/catégories et sur les top/bottom bars d'un article
* Réduction de la luminosité des images en mode dark
# Conflicts:
#	layouts/partials/head.html
#	layouts/partials/script.html
#	static/js/script-yacuutxfvt1eujntvbzebtp3wsud1vohvqlhycduoqw63cdrjpjvhfdasa.min.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants