Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added norwegian and hreflang #411

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tobiasmcvey
Copy link

@tobiasmcvey tobiasmcvey commented Apr 5, 2020

Added

  • Norwegian localisation of homepage
  • Autogenerating hreflang tags for translated content so Google knows about each version
  • Language selection bar

@tobiasmcvey tobiasmcvey closed this Apr 5, 2020
@tobiasmcvey tobiasmcvey deleted the norsk-hreflang branch April 5, 2020 17:05
@tobiasmcvey tobiasmcvey restored the norsk-hreflang branch April 5, 2020 17:07
@kakawait
Copy link
Owner

kakawait commented Apr 5, 2020

@tobmcv why did you close that MR? I'm pretty interessed by your additions

@tobiasmcvey
Copy link
Author

I was trying to make it work on my copy of the repo first and mistakenly submitted it too early. I've managed to make it work now so I'll resubmit my suggestions.

@tobiasmcvey tobiasmcvey reopened this May 1, 2020
Removed the language selector since this doesn't look good for the end user. 

Left the hreflang tag generator in place. This generates link tags to pages in the translated languages so that Google can serve the most relevant translated page in search results to users.
Copy link
Author

@tobiasmcvey tobiasmcvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated the branch now. It only adds 2 things now

  • A yaml file for Norwegian bokmål, one of the 2 written official versions of Norwegian.
  • A function that generates hreflang tags for translated pages on a multilingual blog. These tags are respected by Google and will show the most relevant translated page in search results for people.

Hreflang tags use ISO-codes and can be used to specify languages as well as combinations of languages and country targeting.

Read more about hreflang and the ISO-codes here https://support.google.com/webmasters/answer/189077?hl=en

@tobiasmcvey
Copy link
Author

@kakawait can you review the PR now? It's as complete as I can make it right now.

@kakawait
Copy link
Owner

kakawait commented May 2, 2020

@tobiasmcvey I'll do on next day. Thank you for contribution

@kakawait kakawait added this to the 0.5.1-BETA milestone Jul 30, 2021
@kakawait kakawait self-assigned this Jul 30, 2021
@kakawait kakawait added the enhancement New feature or request label Jul 30, 2021
@kakawait kakawait modified the milestones: 0.5.1-BETA, 0.5.2-BETA Aug 27, 2021
@kakawait
Copy link
Owner

kakawait commented Sep 8, 2021

@tobiasmcvey sorry for delay (see https://github.com/kakawait/hugo-tranquilpeak-theme/blob/master/CHANGELOG.md#forwords for more details).

Since you've created there were new keys, do you think you can translate it? I'm totally zero on Norwegian :)

See diff: https://www.diffchecker.com/UtlKyBsw

- id: "global.read_more_about_author"
  translation: "Read more about the author"
- id: "global.zoom_in_on_picture"
  translation: "Zoom in on the picture"
- id: "global.go_to_homepage"
  translation: "Go to homepage"
- id: "global.open_link"
  translation: "Open the link"
- id: "global.open_post"
  translation: "Open the post"
- id: "post.comment"
  translation: "Leave a comment"
- id: "post.back_to_top"
  translation: "Back to top"
- id: "post.share"
  translation: "Share this post"
- id: "post.gallery"
  translation: "Gallery"
- id: "post.image.one"
  translation: "image"
- id: "post.image.other"
  translation: "{n} images"

@kakawait kakawait added the waiting for feedback We need additional information before we can continue label Sep 8, 2021
@kakawait kakawait modified the milestones: 0.5.2-BETA, 0.6.0-BETA Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request waiting for feedback We need additional information before we can continue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants