Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not showing in main cat if showed in sub cat #346

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Shadowsong27
Copy link

This PR addresses the duplicated display in category page.

If configured to hierarchical categories, post will be present in both the main category and the sub-category.

This if statement ensures a post will only show in main category list if it does not have any sub category declared.

@kakawait kakawait changed the base branch from master to develop July 3, 2019 07:37
@kakawait kakawait added this to the 0.4.5-BETA milestone Jul 3, 2019
@kakawait
Copy link
Owner

kakawait commented Jul 3, 2019

Is not really a bug, is just the behavior from original/upstream theme (https://louisbarranqueiro.github.io/hexo-theme-tranquilpeak/all-categories/)

But we could add param to toggle the behavior.

@kakawait kakawait modified the milestones: 0.4.5-BETA, 0.5.0 Jul 3, 2019
@Shadowsong27
Copy link
Author

@kakawait

True, hence the branch feature/*. Makes more sense to hide them from my perspective.

Thanks.

@kakawait kakawait added the enhancement New feature or request label Jul 14, 2019
@kakawait kakawait self-assigned this Mar 29, 2020
@kakawait kakawait modified the milestones: 0.5.0-BETA, 0.6.0-BETA Mar 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants