Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let eugene filter out unmodified scripts using git #100

Merged
merged 2 commits into from
Jun 9, 2024
Merged

Conversation

kaaveland
Copy link
Owner

@kaaveland kaaveland commented Jun 8, 2024

By passing -g main, eugene lint and eugene trace can ignore scripts that are identical on the main branch. This makes it much easier to use eugene in CI, since it can do something useful on feature branches. -g accepts an arbitrary gitref expression such as a tag or HEAD~100 etc. For now it defaults to being disabled.

Feels like this is going to be as close as we're getting to #89 and #35, which are both fundamentally about the same thing. Need to document this before we merge it.

@kaaveland
Copy link
Owner Author

kaaveland commented Jun 8, 2024

Remaining:

  • Update the documentation
  • Figure out why tests fail in CI
  • Check how this interacts with passing - on the command line for stdin
  • Default -g to None and simplify by assuming any Some() is a ref for git.

@kaaveland kaaveland force-pushed the add-git-smarts branch 7 times, most recently from 291a7b0 to e77c52e Compare June 9, 2024 17:17
By passing -g ref:main, `eugene lint` and `eugene trace` can ignore scripts that
are identical on the main branch. This makes it much easier to use eugene in CI,
since it can do something useful on feature branches. `-g ref:` accepts an
arbitrary gitref expression such as a tag or `HEAD~100` etc. For now it defaults
to `-off`.
@kaaveland kaaveland changed the title Teach eugene to filter out unmodified scripts Let eugene filter out unmodified scripts using git Jun 9, 2024
@kaaveland kaaveland merged commit aeda53a into main Jun 9, 2024
9 checks passed
@kaaveland kaaveland deleted the add-git-smarts branch June 9, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant