Skip to content

Commit

Permalink
Not exposed APIReadyCheckFunc to outside of package
Browse files Browse the repository at this point in the history
APIReadyCheckFunc is used only in api, hence it can be decapitalize
to make its scope only in this package. This fix changes its scope.
In addition, api.APIReadyCheckFunc seems to be redundant so the name
is changed. Change the comment to fit to golang style, too.
  • Loading branch information
s1061123 committed May 24, 2024
1 parent 9f5c023 commit d23856b
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions pkg/server/api/shim.go
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@ type ShimNetConf struct {
LogToStderr bool `json:"logToStderr,omitempty"`
}

// Define a type for API readiness check functions
type APIReadyCheckFunc func(string) error
// readyCheckFunc defines a type for API readiness check functions
type readyCheckFunc func(string) error

// CmdAdd implements the CNI spec ADD command handler
func CmdAdd(args *skel.CmdArgs) error {
Expand Down Expand Up @@ -74,7 +74,7 @@ func CmdDel(args *skel.CmdArgs) error {
return nil
}

func postRequest(args *skel.CmdArgs, readinessCheck APIReadyCheckFunc) (*Response, string, error) {
func postRequest(args *skel.CmdArgs, readinessCheck readyCheckFunc) (*Response, string, error) {
multusShimConfig, err := shimConfig(args.StdinData)
if err != nil {
return nil, "", fmt.Errorf("invalid CNI configuration passed to multus-shim: %w", err)
Expand Down

0 comments on commit d23856b

Please sign in to comment.