feat: skip k3s node type EtcdIsVoter
#1167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuHyung-Son
reviewed
Jun 30, 2024
yankay
force-pushed
the
skip-k3s-node-type
branch
from
52560c3
to
991dd31
Compare
Yes, it's only for k3s |
Signed-off-by: Kay Yan <[email protected]>
yankay
force-pushed
the
skip-k3s-node-type
branch
from
991dd31
to
2eb9346
Compare
JuHyung-Son
reviewed
Jul 3, 2024
|
I am inclined to agree that if this unblocks errors in k3s then we should add it. Anyone else @k8sgpt-ai/k8sgpt-maintainers ? |
|
no objections from my side, looks safe :) @AlexsJones |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1166
📑 Description
Skip k3s node Condition EtcdIsVoter Status reported as an error.
✅ Checks
ℹ Additional Information