-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use higher QPS for secrets reencryption #10571
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Nola <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10571 +/- ##
==========================================
- Coverage 49.37% 43.56% -5.82%
==========================================
Files 179 179
Lines 14950 14951 +1
==========================================
- Hits 7382 6513 -869
- Misses 6207 7244 +1037
+ Partials 1361 1194 -167
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
brandond
requested changes
Jul 25, 2024
Signed-off-by: Derek Nola <[email protected]>
brandond
approved these changes
Jul 25, 2024
vitorsavian
approved these changes
Jul 26, 2024
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
Aug 5, 2024
* Use higher QPS for secrets reencryption Signed-off-by: Derek Nola <[email protected]>
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
Aug 5, 2024
* Use higher QPS for secrets reencryption Signed-off-by: Derek Nola <[email protected]>
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
Aug 5, 2024
* Use higher QPS for secrets reencryption Signed-off-by: Derek Nola <[email protected]>
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
Aug 5, 2024
* Use higher QPS for secrets reencryption Signed-off-by: Derek Nola <[email protected]>
This was referenced Aug 5, 2024
dereknola
added a commit
that referenced
this pull request
Aug 6, 2024
* Use higher QPS for secrets reencryption Signed-off-by: Derek Nola <[email protected]>
dereknola
added a commit
that referenced
this pull request
Aug 6, 2024
* Use higher QPS for secrets reencryption Signed-off-by: Derek Nola <[email protected]>
dereknola
added a commit
that referenced
this pull request
Aug 6, 2024
* Use higher QPS for secrets reencryption Signed-off-by: Derek Nola <[email protected]>
dereknola
added a commit
that referenced
this pull request
Aug 6, 2024
* Use higher QPS for secrets reencryption Signed-off-by: Derek Nola <[email protected]>
This was referenced Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Types of Changes
Feature Enhancement
Verification
Time to reencrypt 1000 "basic" secrets (secrets are simple strings)
Time to reencrypt 200 "large" secrets (1000K size, aka the maximum secret size)
Testing
Already Covered
Linked Issues
#10581
User-Facing Change
Further Comments
This dramatically cuts the time for secrets encryption. It is possible we no longer even need a controller for this task, as even with 10K+ secrets, the timeline is now seconds not tens of minutes.