Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wire lasso metrics up to metrics endpoint #10528

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

brandond
Copy link
Contributor

@brandond brandond commented Jul 16, 2024

Proposed Changes

Wire lasso metrics up to common registerer/gatherer.

This exposes perf metrics for the Lasso controllers embedded in the supervisor.

Waiting on:

Types of Changes

enhancement

Verification

kubectl get --raw /metrics | grep lasso

Testing

Linked Issues

User-Facing Change

Further Comments

@brandond brandond requested a review from a team as a code owner July 16, 2024 01:40
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.53%. Comparing base (37830fe) to head (0e388a9).
Report is 2 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (37830fe) and HEAD (0e388a9). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (37830fe) HEAD (0e388a9)
e2etests 9 6
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10528      +/-   ##
==========================================
- Coverage   49.66%   43.53%   -6.14%     
==========================================
  Files         179      179              
  Lines       14936    14938       +2     
==========================================
- Hits         7418     6503     -915     
- Misses       6158     7239    +1081     
+ Partials     1360     1196     -164     
Flag Coverage Δ
e2etests 36.34% <100.00%> (-10.24%) ⬇️
inttests 36.78% <100.00%> (+17.06%) ⬆️
unittests 13.36% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Looking at metrics revealed the cloudprovider controller name was anempty string.

Signed-off-by: Brad Davidson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants