Start using flake8 #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow, automated building and testing with Travis CI, that wasn't there yesterday? Awesome! |
|
Yeah when I started the project I didn't knew about linting, nowadays I use mostly autopep8, but flake8 is fine too. You're right, it should be applied to this project. I'll check locally this weekend I hope, and push the changes. Regarding CI, I've enabled it after merging your commits yesterday, I was tired of manually building and pushing to pypi. So now it's all automated through GitHub actions ! when a release is created, it'll build and push the new version on pypi. Quite cool I think :D |
|
Some update on the use of flake8, I'm setting up an automated GitHub action for it so that it can check automatically before publishing if everything is fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a suggestion: In other python projects I am involved in, the use of Flake8 for linting is often required. I have already reformatted a lot, but flake still complains a lot...
If you don't want that or prefer another linter, that's no problem!