Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: improvements on the handling of amount #18

Merged
merged 9 commits into from
Apr 3, 2024
Merged

Conversation

jy95
Copy link
Owner

@jy95 jy95 commented Apr 3, 2024

FHIR had reused many times these data structures across the Dosage object :

Let's make some cleanup in the handling

Copy link

codacy-production bot commented Apr 3, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (0e3170b) 447 447 100.00%
Head commit (122f63e) 463 (+16) 463 (+16) 100.00% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#18) 68 68 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

Copy link

netlify bot commented Apr 3, 2024

Deploy Preview for fhir-dosage-utils ready!

Name Link
🔨 Latest commit 122f63e
🔍 Latest deploy log https://app.netlify.com/sites/fhir-dosage-utils/deploys/660dcb8656266200088cc620
😎 Deploy Preview https://deploy-preview-18--fhir-dosage-utils.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jy95 jy95 merged commit 1251b7e into main Apr 3, 2024
13 checks passed
@jy95 jy95 deleted the ratio-improvements branch April 3, 2024 21:50
Copy link

github-actions bot commented Apr 3, 2024

🎉 This PR is included in version 1.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant