restore async groq functionality #704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 5d0bcf7 in 1 minute and 16 seconds
More details
- Looked at
32lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_rJsP2YWBxOSm1XMX
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restoring the ability to use Groq async. Was accidentally broken during this refactor.
Tested it locally and groq requests now trigger in parallel (assuming one passed in
AsyncGroq). Using syncGroqworks the same.Summary:
Restores asynchronous functionality for Groq in
instructor/client_groq.pyby correctly handlinggroq.AsyncGroqclients.Key points:
instructor/client_groq.py.from_groqfunctions to handlegroq.AsyncGroqcorrectly.Generated with ❤️ by ellipsis.dev