Close connections #164
Merged
Close connections #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an unread response body exists, http.Client cannot reuse the TCP connection for the next request.
If the server cannot accept multiple TCP connections, dockerize's test connection fills the server's slot. Test connection should be closed.
ruudk
reviewed
Sep 9, 2021
|
|
Thanks, TIL 😊 |
jwilder
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. This PR enables close test connections and HTTP response.
dockerize keeps a test TCP connection while running, but if the server cannot accept multiple TCP connections, the test connection fills the server's slot. It should be closed.
dockerize does not read HTTP response body and does not close it now.
When an unread response body exists, http.Client cannot reuse the TCP connection for the next request.